[Android] refactoring fixes layouts

[paymicro]

Description of Change

Refactoring fixes layouts

Issues Resolved

• refactoring Regression Issue - Content set after an await is not visible #1760 (PR [Android] fixes redraw element when changing renderer #5233)
• refactoring [Android] ListView grouping broken with 3.5.0 #5184 (PR [Android] fixes redraw element when changing renderer #5233)
• refactoring [Android / Fast Renderer] Frame size gets corrupted when ListView is scrolled #5766 (PR [Android] Fix Frame size #6115)
• closes [Android] ListView grouping broken with 3.5.0 #5184
• fixes [Bug] Listview with custom viewcell renders wrongly after XF4.0 update #6297
• fixes [Bug] Xamarin Forms 4 regression: ListView display glitches #6355
• fixes [Bug] ListView showing empty items on XF4 #6439
• fixes [Android] 4.0.1.305340-nightly breaks ListView recylcing #5838
• fixes [Bug] ListView DataTemplate Label text cutting in Xamarin.Forms 4.0 #6447
• fixes CollectionView Scrolling causing some Views to Disappear #6767
• fixes [Android] ListView item UI contents are corrupted #6830
• fixes [Bug] OnPropertyChanged sometimes does not update UI in ListView, only after scroll or another activity #6841
• fixes [Bug] [Android] Listview does not fully paint element when scrolling quickly using RecylceElement #6670
• does not fix [Bug] CollectionView on android (not test on iOS) lable binding show blank after do some scroll #6889
• fixes Binding Image.IsVisible in ListView ItemTemplate is broken in Android #6899
• fixes [Bug] ListView blank cells when CachingStrategy="RetainElement" on Android #6721

API Changes

None

Platforms Affected

• Android

Behavioral/Visual Changes

None

Before/After Screenshots

ListView display glitches
Before
#6355 http://recordit.co/QBMYFWyF0R

After
#6355 http://recordit.co/VBa2CAtHJt
Issue #6439 http://recordit.co/jNVIM4wkGd

Testing Procedure

Fast Renderers and Legacy Renderers

• UITest 1332
• UITest 1760
• UITest 1760_1
• UITest 5766
• UITest 5184
• UITest 6297
• Issue6282

PR Checklist

• Has automated tests
• Rebased on top of the target branch at time of PR
• Changes adhere to coding standard

[PureWeen]

All the android UI tests look like they failed

https://devdiv.visualstudio.com/DevDiv/_releaseProgress?releaseId=347750&_a=release-pipeline-progress

[PouryaNoufallah96]

@jingliancui

<Frame Style="{StaticResource FrameSectionStyle}"> <Grid> <Grid.ColumnDefinitions> <ColumnDefinition Width="*" /> </Grid.ColumnDefinitions> <StackLayout> <StackLayout Orientation="Horizontal"> <Label Style="{StaticResource TextListHeadline}" Text="{Binding CustomerName}" /> <Label Style="{StaticResource TextTitle}" Text="{Binding CustomerCode}" /> </StackLayout> <StackLayout Orientation="Horizontal"> <Label Margin="20,0,0,0" Style="{StaticResource TextBody}" Text="{Binding Mobile}" /> <Label Style="{StaticResource TextBody}" Text="{Binding Telephone}" /> </StackLayout> <Label Style="{StaticResource TextCaption}" Text="{Binding Address}" /> </StackLayout> </Grid> </Frame>

this is my listview item template . i monitored that page but it doesnt help:(

[PouryaNoufallah96]

@jingliancui i realized that when i put CachingStrategy="RecycleElement" this bug shows on scrolling . but now i erase the CachingStrategy property it solved my issue . but whats the solution ? i need CachingStrategy =RecycleElement

[adrianknight89]

@jingliancui The question was intended for the Forms team :)

[adrianknight89]

@PouryaNoufallah96 You could try using a nightly build by setting your Nuget package source to https://aka.ms/xf-ci/index.json, but I believe this fix hasn't been built yet since the latest nightly has issues still.

[marunprasadbe13]

Could you please confirm whether this fix would be included in any of the upcoming Xamarin.Forms releases ? It is required to resolve all the ListView related issues in Android.

[PouryaNoufallah96]

even the search handlers item templates has this issue on scrooling :(

[fpiribauer]

@marunprasadbe13 there are already tags for the next service releases. Seems like the relevant commits are included.

[adrianknight89]

@hartez @PureWeen I just updated to 4.3.0.971-nightly. It fixes my ListView display issues, but ListView scrolling on Android is broken. I have to swipe up and down several times before scrolling can begin (happens 50% of the cases). I'm not sure if the issue is related to this PR.

Edit: Looks like this has to do with the addition of nested scrolling as described here.

[PureWeen]

@adrianknight89 Yea we'll have that one fixed soon.

My other thought was that perhaps you were hitting this issue on the nightly
#6944 (comment)

We're seeing a few of our UI tests locking up right now from that which we'll have resolved here soon

[mfeingol]

@samhouts: any idea which release versions will see these fixes?

Thanks.

[morphinapg]

@mfeingol I installed 4.1.0.618606 and it solved my issues

[mfeingol]

@morphinapg: thanks! That version does seem to have fixed my issues on Android.

[jingliancui]

#6889
this bug still not fix in 4.1.0.618606

[mdmota]

this bug still not fix in 4.2.0

[nicolasmab]

In 4.2.0, a ListView with RecycleElement, and Images with IsVisible property is still causing images to randomly appear in rows that shouldn't. This occurs after some scrolling, in both iOS and Android. (This was working fine in 3.6)

As a workaround until this is fixed, the IsVisible property can be moved inside an <Image.Trigger>:

From:

<Image Source="comment.png"
       IsVisible="{Binding HasComment}" />

To

<Image Source="comment.png">
    <Image.Triggers>
        <DataTrigger TargetType="Image" Binding="{Binding HasComment}" Value="True">
            <Setter Property="IsVisible" Value="True" />
        </DataTrigger>
        <DataTrigger TargetType="Image" Binding="{Binding HasComment}" Value="False">
            <Setter Property="IsVisible" Value="False" />
        </DataTrigger>
    </Image.Triggers>
</Image>

[DavidCFreire]

Any news on that? having same issues here with XF4.0 or XF4.1

[DavidCFreire]

I just updated to XF4.3.0.778476-pre1 and apparently this solved the problem... no problems until now

[mdmota]

this bug still not fix in XF4.3.0.778476-pre3

[mdmota]

After upgrading XF to 4.3.0 and replacing listivew with colletionView, the problem continues
#8199 (comment)

[SachinCS1992]

This PR seems have to introduced a new issue on Android Editor, where if the Editor lives inside a ScrollView, on first load of Editor we can't select the words to be able to copy/paste/select all text. If we flip device orientation, it fixes the issue. Tried reverting commit locally and re-published a package and that fixed the issue.