Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Don't publish any *.o files that comes from NativeAOT. #18904

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Sep 1, 2023

If anything we're supposed to link with *.o files, not publish them, but since
we're currently not handling any *.o files, just explicitly remove them from
the build. This avoids a warning where ComputeBundleLocation would issue a
warning about not knowing what to do with them.

Contributes towards #18629.

If anything we're supposed to link with *.o files, not publish them, but since
we're currently not handling any *.o files, just explicitly remove them from
the build. This avoids a warning where ComputeBundleLocation would issue a
warning about not knowing what to do with them.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 9e69ad0e004a4880909c9efeef94b62c52bd2672 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@filipnavara
Copy link
Contributor

This is worrying me. There are two .o files that should be in runtime pack, and we should link against one of them.

https://github.com/dotnet/runtime/blob/9e16f0985a83f6d3086c79e4ac2528b45f2bfff4/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets#L57

I assume we do link against it because it does the runtime initialisation but it should be double checked.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 9e69ad0e004a4880909c9efeef94b62c52bd2672 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 233 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 9e69ad0e004a4880909c9efeef94b62c52bd2672 [PR build]

Copy link
Contributor

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Re:

This is worrying me. There are two .o files that should be in runtime pack, and we should link against one of them.

https://github.com/dotnet/runtime/blob/9e16f0985a83f6d3086c79e4ac2528b45f2bfff4/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets#L57

I assume we do link against it because it does the runtime initialisation but it should be double checked.

Yes, we are linking against: libbootstrapperdll.o (2x checked)

Co-authored-by: Ivan Povazan <55002338+ivanpovazan@users.noreply.github.com>
@rolfbjarne rolfbjarne merged commit 50071c3 into xamarin:net8.0 Sep 5, 2023
5 checks passed
@rolfbjarne rolfbjarne deleted the nativeaot-skip-object-files branch September 5, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants