Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Don't publish any *.o files that comes from NativeAOT. #18904

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[NativeAOT] Don't publish any *.o files that comes from NativeAOT. #18904

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e69ad0
[NativeAOT] Don't publish any *.o files that comes from NativeAOT.
rolfbjarne Sep 1, 2023
b5e67bf
Update dotnet/targets/Xamarin.Shared.Sdk.targets
rolfbjarne Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,6 +1727,18 @@
"
/>

<!-- There's no need to ship any *.o files shipped by NativeAOT -->
<!-- We need to remove these from ResolvedFileToPublish before calling ComputeBundleLocation, because otherwise we get warnings about no knowing what to do with these files -->
rolfbjarne marked this conversation as resolved.
Show resolved Hide resolved
<ResolvedFileToPublish
Remove="@(ResolvedFileToPublish)"
Condition=" '%(ResolvedFileToPublish.AssetType)' == 'native' And
'%(ResolvedFileToPublish.RuntimeIdentifier)' == '$(RuntimeIdentifier)' And
'%(ResolvedFileToPublish.Extension)' == '.o' And
'%(ResolvedFileToPublish.NuGetPackageId)' == '$(_MonoNugetPackageId)' And
'$(_UseNativeAot)' == 'true'
"
/>

<!-- Put the 'createdump' executable in the expected location in the app bundle when using CoreCLR -->
<!-- Ref: https://github.com/xamarin/xamarin-macios/issues/11432 -->
<_CreateDumpExecutable
Expand Down
Loading