Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded vec128 and VectorSub #574

Merged
merged 2 commits into from
Jun 5, 2016
Merged

Expanded vec128 and VectorSub #574

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ca689
Expanded vec128 and VectorSub
HaydnTrigg May 16, 2016
ff55297
clang-format to Google Standards
HaydnTrigg May 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/xenia/base/vec128.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ typedef struct alignas(16) vec128_s {
uint32_t uz;
uint32_t uw;
};
float f32[4];
float f32[4];
double f64[2];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format this too please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the formatting for this file was okay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be spaces instead of tabs

Copy link
Contributor Author

@HaydnTrigg HaydnTrigg May 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Also squashed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the SSE and AVX stuff. I noticed Halo Reach and Halo 3 use this code a lot and when I debugged it appeared to be positional co-ordinates, thats why I was eager to smash out some faster code for it

int8_t i8[16];
uint8_t u8[16];
int16_t i16[8];
Expand Down
97 changes: 74 additions & 23 deletions src/xenia/cpu/hir/value.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,29 +1004,80 @@ void Value::VectorRol(Value* other, TypeName type) {
}

void Value::VectorSub(Value* other, TypeName type, bool is_unsigned,
bool saturate) {
assert_true(this->type == VEC128_TYPE && other->type == VEC128_TYPE);
switch (type) {
case INT32_TYPE:
for (int i = 0; i < 4; i++) {
if (is_unsigned) {
if (saturate) {
assert_always();
} else {
constant.v128.u32[i] -= other->constant.v128.u32[i];
}
} else {
if (saturate) {
assert_always();
} else {
constant.v128.i32[i] -= other->constant.v128.i32[i];
}
}
}
default:
assert_unhandled_case(type);
break;
}
bool saturate) {
assert_true(this->type == VEC128_TYPE && other->type == VEC128_TYPE);
switch (type) {
case FLOAT32_TYPE:
if (saturate) assert_always();
Copy link
Member

@DrChat DrChat May 19, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surround if statements in curly brackets please. Ditto for everything below.

else
{
constant.v128.x -= other->constant.v128.x;
constant.v128.y -= other->constant.v128.y;
constant.v128.z -= other->constant.v128.z;
constant.v128.w -= other->constant.v128.w;
}
break;
case INT32_TYPE:
if (saturate) assert_always();
else
{
for (int i = 0; i < 4; i++)
{
if (is_unsigned) constant.v128.u32[i] -= other->constant.v128.u32[i];
else constant.v128.i32[i] -= other->constant.v128.i32[i];
}
}
break;
case FLOAT64_TYPE:
if (saturate) assert_always();
else
{
constant.v128.f64[0] -= other->constant.v128.f64[0];
constant.v128.f64[1] -= other->constant.v128.f64[1];
}
break;
case INT8_TYPE:
if (saturate) assert_always();
else
{
for (int i = 0; i < 16; i++)
{
if (is_unsigned) constant.v128.u8[i] -= other->constant.v128.u8[i];
else constant.v128.i8[i] -= other->constant.v128.i8[i];
}
}
break;
case INT16_TYPE:
if (saturate) assert_always();
else
{
for (int i = 0; i < 9; i++)
{
if (is_unsigned) constant.v128.u16[i] -= other->constant.v128.u16[i];
else constant.v128.i16[i] -= other->constant.v128.i16[i];
}
}
break;
case INT64_TYPE:
if (saturate) assert_always();
else
{
if (is_unsigned)
{
constant.v128.u64[0] -= other->constant.v128.u64[0];
constant.v128.u64[1] -= other->constant.v128.u64[1];
}
else
{
constant.v128.i64[0] -= other->constant.v128.i64[0];
constant.v128.i64[1] -= other->constant.v128.i64[1];
}
}
break;
default:
assert_unhandled_case(type);
break;
}
}

void Value::ByteSwap() {
Expand Down