Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange datatype of unique_edge_size() #566

Closed
maximelucas opened this issue Aug 1, 2024 · 1 comment · Fixed by #567
Closed

strange datatype of unique_edge_size() #566

maximelucas opened this issue Aug 1, 2024 · 1 comment · Fixed by #567

Comments

@maximelucas
Copy link
Collaborator

Running

H = xgi.load_xgi_data("email-enron")
xgi.unique_edge_sizes(H)

yields

[np.int64(1),
 np.int64(2),
 np.int64(3),
...
 np.int64(36),
 np.int64(37)]

I don't remember these elements being np.int64. There's probably nothing wrong with it but it looks unnecessary.
This might be due to the new numpy version 2.0?

@nwlandry
Copy link
Collaborator

nwlandry commented Aug 1, 2024

Yes, that's correct! If you want to make a quick PR casting the values to int and adding a short test confirming the data type, I'll approve it!

maximelucas added a commit that referenced this issue Aug 1, 2024
@maximelucas maximelucas mentioned this issue Aug 1, 2024
maximelucas added a commit that referenced this issue Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants