-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change aggregate stats type and added unique
method.
#603
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 93.21% 93.24% +0.02%
==========================================
Files 62 62
Lines 4733 4735 +2
==========================================
+ Hits 4412 4415 +3
+ Misses 321 320 -1 ☔ View full report in Codecov by Sentry. |
unique()
method to statsunique
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a little context? What is this new numpy float type? What versions is it available in? Do we want to pin the numpy version?
@leotrs --- thanks for the review! Numpy 2.0 created breaking changes, which resulted in Issues #544 and #566. Numpy made the decision to use their own float and int datatypes (np.int32, np.int64, etc.) (not sure why), and we made the decision that the traditional Python types are preferable. |
The way we are handling the Numpy interface now is largely backwards-compatible, so we will also be able to use Numpy versions <2.0. |
This PR does the following:
max
,min
, etc.) the classic float type instead of the new numpy type.unique
method to the statistics interface.