vcut: fix segmentation fault caused by submit_headers_to_stream() #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a regression in vcut that caused a segmentation fault every time I run this program. It was introduced by commit f7cb48a (Flush stream after the third header packet, and delay the writing of … ) In submit_headers_to_stream(), vs->headers is only 3 structures long (as defined in vcut.h) so accessing vs->headers[3] is certainly a mistake. Moreover, in this function, i is always smaller then 4 so the comparision "if(i < 4)" makes no sense. The Author probably intended to write "if (i<3)", which fits with the logic in commit f7cb48a . I was using Ubuntu 16.04 i386.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression in vcut that caused a segmentation fault every time I run this program.
It was introduced by commit f7cb48a (Flush stream after the third header packet, and delay the writing of … )
In
submit_headers_to_stream(),vs->headersis only 3 structures long (as defined invcut.h) so accessingvs->headers[3]is certainly a mistake. Moreover, in this function, i is always smaller then 4 so the comparisionif(i < 4)makes no sense. The Author probably intended to writeif (i<3), which fits with the general modifications ofsubmit_hedears_to_streamin commit f7cb48a .I am running Ubuntu 16.04 i386, maybe this bug does not cause segmentation faults on 64-bit architectures.