Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcut: fix segmentation fault caused by submit_headers_to_stream() #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vcut: fix segmentation fault caused by submit_headers_to_stream() #23

wants to merge 1 commit into from

Commits on Mar 21, 2020

  1. vcut: fix segmentation fault caused by submit_headers_to_stream() 

    There was a regression in vcut that caused a segmentation fault every time I run this program.
It was introduced by commit f7cb48a (Flush stream after the third header packet, and delay the writing of … )

In submit_headers_to_stream(), vs->headers is only 3 structures long (as defined in vcut.h) so accessing vs->headers[3] is certainly a mistake. Moreover, in this function, i is always smaller then 4 so the comparision "if(i < 4)" makes no sense. The Author probably intended to write "if (i<3)", which fits with the logic in commit f7cb48a .

I was using Ubuntu 16.04 i386.
    @matjon
    matjon authored Mar 21, 2020
    Configuration menu
    Copy the full SHA
    8011859 View commit details
    Browse the repository at this point in the history