Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature not always the same #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions Tests/XMTPTests/ClientTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -492,4 +492,41 @@ class ClientTests: XCTestCase {
let newState = try await alixClient3.inboxState(refreshFromNetwork: true)
XCTAssertEqual(newState.installationIds.count, 1)
}

func testSignMessage() async throws {
let key = try Crypto.secureRandomBytes(count: 32)
let alix = try PrivateKey.generate()
let options = ClientOptions.init(
api: .init(env: .local, isSecure: false),
enableV3: true,
encryptionKey: key
)

let alixClient = try await Client.create(
account: alix,
options: options
)
let privateKey = try PrivateKey(alixClient.keys.identityKey)

let stringToSign1 = "TEST_STRING_TO_SIGN"

let signature1_1 = try await privateKey.sign(stringToSign1.data(using: .utf8)!)
let uint1_1 = try [UInt8](signature1_1.serializedData())

let signature1_2 = try await privateKey.sign(stringToSign1.data(using: .utf8)!)
let uint1_2 = try [UInt8](signature1_2.serializedData())

XCTAssertEqual(uint1_1, uint1_2)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one passes


let stringToSign2 = "short"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at first I thought it was because the string was short but I managed to make it fail with longer strings also… maybe a byte length thing?


let signature2_1 = try await privateKey.sign(stringToSign2.data(using: .utf8)!)
let uint2_1 = try [UInt8](signature2_1.serializedData())

let signature2_2 = try await privateKey.sign(stringToSign2.data(using: .utf8)!)
let uint2_2 = try [UInt8](signature2_2.serializedData())

XCTAssertEqual(uint2_1, uint2_2)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one fails

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems strange. Will add it to the backlog for investigation.

}

}
Loading