Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications such as vim and htop hang, occurs in demo and own project #451

Closed
pparke opened this issue Jan 4, 2017 · 2 comments
Closed
Assignees
Labels
important type/bug Something is misbehaving

Comments

@pparke
Copy link

pparke commented Jan 4, 2017

I'm not sure if there is an issue with running programs such as vim or htop but after I cloned the repo and tried running the demo I'm able to use the terminal in my browser until I enter a program such as vim. After that it seems as though all input and output ceases.

I've tried setting up a few different back ends just in case that was the issue (tty.js, the one included in the demo, an adaptation of ttyd) and I get the same issue every time. I've also tried logging the data that is being received on the socket and I see output right up until I start vim/htop and then all output ceases. I do see a closed event fired when I close the client.

I've even tried sending data manually from the client using term.send() just in case there was some issue client side. I'm hoping that there's an easy fix to this and that I'm just overlooking something but since it happens when I run the demo I'm not so certain. I've removed node_modules and rebuilt as well just in case.

I had a colleague try cloning and building on his machine but it complains about the @types/mocha dependency.

If anyone has any suggestions or tips I'd be happy for the help.

Details

  • Browser and browser version:
    Chrome 55.0.2883.87 (64-bit)
    Opera 36.0.2130.65

  • OS version:
    Xubuntu 4.4.0-57-generic

  • xterm.js version:
    2.2.3

Steps to reproduce

  1. I cloned the repo and ran npm install and npm start and then visited localhost:3000
  2. run vim or htop and try to use any of the keys, terminal will be inactive
@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2017

Yes I can reproduce, this is to do with #432 so you can move back before that was merged and it should work in the meantime 23472e6

@Tyriar Tyriar self-assigned this Jan 4, 2017
@Tyriar Tyriar added type/bug Something is misbehaving important labels Jan 4, 2017
@pparke
Copy link
Author

pparke commented Jan 4, 2017

That worked, thanks so much 😃

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jan 8, 2017
This broke in the EventEmitter ts conversion, just reverts this line to what
it used to be.

Fixes xtermjs#451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants