-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build aarch64 take 2 #119
Build aarch64 take 2 #119
Conversation
friendly ping @Waidhoferj |
@@ -3,6 +3,7 @@ name: Build and Release | |||
on: | |||
release: | |||
types: [published] | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kafonek before trying the deploy, is there a reason that we trigger the wheel build on PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goal here is to raise some of the errors we've been seeing before getting to a release action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a bit overkill to run it on every PR, since we only need to check on PRs immediately before a release. Maybe we could use workflow_dispatch
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to using that and manually kicking off actions if you want to add me to the repo with write access 🙏 I feel bad that there's so many release action failures based on some CI PR's I've put in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate the work you put into this. Wish it wasn't so hard to verify. Unfortunately, I don't have control over read/write access to the repo, but I think @dmonad can help with this.
@Waidhoferj do you mind deleting and re-releasing 0.5.6 to see if it will build and upload wheels to pypi this time? Or bump the version and release 0.5.7? Thanks! |
I see v0.5.6 as the latest release on GitHub, even though there is a v0.5.7. |
Fixes for the failures we saw in #115 / https://github.com/y-crdt/ypy/actions/runs/4167129650
py-dissimilar
CI https://github.com/messense/py-dissimilar/blob/main/.github/workflows/CI.yml