Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-viewer-webui: Update yscope-log-viewer to the latest version (which uses clp-ffi-js). #562

Merged
merged 3 commits into from
Oct 24, 2024
Merged

log-viewer-webui: Update yscope-log-viewer to the latest version (which uses clp-ffi-js). #562

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9863986
Update `yscope-log-viewer` to the latest version.
junhaoliao Oct 23, 2024
5707218
Update yscope-log-viewer commit id to latest.
junhaoliao Oct 24, 2024
c73bcd6
Replace repo owner with `y-scope` in `yscope-log-viewer` `SRC_URL`.
junhaoliao Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/log-viewer-webui/client/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import QueryStatus from "./ui/QueryStatus.jsx";
*/
const App = () => {
return (
<CssVarsProvider modeStorageKey={LOCAL_STORAGE_KEY.UI_THEME}>
<CssVarsProvider modeStorageKey={LOCAL_STORAGE_KEY.THEME}>
<QueryStatus/>
</CssVarsProvider>
);
Expand Down
2 changes: 1 addition & 1 deletion components/log-viewer-webui/client/src/typings/LOCAL_STORAGE_KEY.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Enum of `window.localStorage` keys.
*/
const LOCAL_STORAGE_KEY = Object.freeze({
UI_THEME: "uiTheme",
THEME: "theme",
});

export default LOCAL_STORAGE_KEY;
2 changes: 1 addition & 1 deletion components/log-viewer-webui/client/src/ui/QueryStatus.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const QueryStatus = () => {

const innerLogEventNum = logEventIdx - data.begin_msg_ix + 1;
window.location = `/log-viewer/index.html?filePath=/ir/${data.path}` +
`#logEventIdx=${innerLogEventNum}`;
`#logEventNum=${innerLogEventNum}`;
})
.catch((e) => {
let msg = "Unknown error.";
Expand Down
2 changes: 1 addition & 1 deletion components/log-viewer-webui/yscope-log-viewer
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this once y-scope/yscope-log-viewer#101 is merged.

Submodule yscope-log-viewer updated 249 files
4 changes: 2 additions & 2 deletions deps-tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,8 +421,8 @@ tasks:
vars:
DEST: "{{.DEST}}"
FLAGS: "--extract"
SRC_NAME: "yscope-log-viewer-c939f7b55b55b42f65226470d5277b15ac484665"
SRC_URL: "https://github.com/y-scope/yscope-log-viewer/archive/c939f7b.zip"
SRC_NAME: "yscope-log-viewer-bc8109f9f371c3327070000dee3537bdaf535428"
SRC_URL: "https://github.com/junhaoliao/yscope-log-viewer/archive/bc8109f.zip"
junhaoliao marked this conversation as resolved.
Show resolved Hide resolved
# This command must be last
- task: ":utils:compute-checksum"
vars:
Expand Down
Loading