Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-viewer-webui: Update yscope-log-viewer to the latest version (which uses clp-ffi-js). #562

Merged
merged 3 commits into from
Oct 24, 2024
Merged

log-viewer-webui: Update yscope-log-viewer to the latest version (which uses clp-ffi-js). #562

merged 3 commits into from
Oct 24, 2024

Conversation

junhaoliao
Copy link
Collaborator

Description

  1. Update submodule yscope-log-viewer commit id to the latest.
  2. Update the commit id in deps-tasks.yml.
  3. Change search parameter name logEventIdx -> logEventNum to match the schema in the updated yscope-log-viewer.
  4. Update LOCAL_STORAGE_KEY.THEME to match the one in the updated yscope-log-viewer.

Validation performed

  1. Referred to the validation steps at Add support for viewing search results in context for text logs (clp-text). #489 , built and started the CLP package, compressed sample log files, and searched with search string "1" in the WebUI and observed file links shown for each result.
  2. Clicked any file links and observed the log viewer opened in a new tab, loaded the file, and positioned the cursor at the desired log event.
  3. In the log viewer, changed the theme setting to "Light". Back in the WebUI, clicked any file links and observed the in the log viewer "extracting IR" loading page, the theme changed to "Light".
  4. Repeated step 3 for theme setting "System" and "Dark" and observed the loading page's got updated accordingly.

junhaoliao
junhaoliao commented Oct 23, 2024
View reviewed changes
components/log-viewer-webui/yscope-log-viewer Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this once y-scope/yscope-log-viewer#101 is merged.

junhaoliao
junhaoliao commented Oct 23, 2024
View reviewed changes
deps-tasks.yml Outdated
Comment on lines 424 to 425
SRC_NAME: "yscope-log-viewer-f15a846f6edfb47656a537aceeb1ebe579f083b7"
SRC_URL: "https://github.com/junhaoliao/yscope-log-viewer/archive/f15a846.zip"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update these once y-scope/yscope-log-viewer#101 is merged.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2024 •
edited
Loading

Warning

Rate limit exceeded

@junhaoliao has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between 65b231b and c73bcd6.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@junhaoliao junhaoliao changed the title [WIP] log-viewer-webui: Update yscope-log-viewer to the latest version. log-viewer-webui: Update yscope-log-viewer to the latest version. Oct 24, 2024
@junhaoliao junhaoliao marked this pull request as ready for review October 24, 2024 02:05
junhaoliao
junhaoliao commented Oct 24, 2024
View reviewed changes
deps-tasks.yml Outdated Show resolved Hide resolved
@davemarco davemarco self-requested a review October 24, 2024 02:48
davemarco
davemarco approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@davemarco davemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuilt package. Compressed README. Then searched and opened log viewer. All seemed to work correctly.

@junhaoliao
Copy link
Collaborator Author

Rebuilt package. Compressed README. Then searched and opened log viewer. All seemed to work correctly.

Thanks for quickly reviewing this! Do you agree with the PR title?

@davemarco
Copy link
Contributor

Maybe log-viewer-webui: Update yscope-log-viewer to new implementation using clp-ffi-js ??

@kirkrodrigues
Copy link
Member

Maybe log-viewer-webui: Update yscope-log-viewer to new implementation using clp-ffi-js ??

How about:

log-viewer-webui: Update `yscope-log-viewer` to the latest version (which uses `clp-ffi-js`).

@junhaoliao junhaoliao changed the title log-viewer-webui: Update yscope-log-viewer to the latest version. log-viewer-webui: Update yscope-log-viewer to the latest version (which uses clp-ffi-js). Oct 24, 2024
@junhaoliao junhaoliao merged commit f549df0 into y-scope:main Oct 24, 2024
18 checks passed
LinZhihao-723 added a commit to LinZhihao-723/clp that referenced this pull request Nov 12, 2024
@LinZhihao-723 @kirkrodrigues
@junhaoliao @Henry8192 @gibber9809 @wraymo @anlowee @haiqi96
Conventional commit (#15)
e6f6c22 
* ffi: Add support for serializing/deserializing auto-generated and user-generated schema tree node IDs. (y-scope#557)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

* clp: Add missing C++ standard library includes in IR parsing files. (y-scope#561)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

* log-viewer-webui: Update `yscope-log-viewer` to the latest version (which uses `clp-ffi-js`). (y-scope#562)

* package: Upgrade dependencies to resolve security issues. (y-scope#536)

* clp-s: Implement table packing (y-scope#466)

Co-authored-by: wraymo <37269683+wraymo@users.noreply.github.com>
Co-authored-by: Kirk Rodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Co-authored-by: wraymo <raywangv@gmail.com>

* log-viewer-webui: Update `yscope-log-viewer` to the latest version. (y-scope#565)

* ci: Switch GitHub macOS build workflow to use macos-13 (x86) and macos-14 (ARM) runners. (y-scope#566)

* core: Add support for user-defined HTTP headers in `NetworkReader`. (y-scope#568)

Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com>
Co-authored-by: Xiaochong Wei <xiaochong.wei@yscope.com>

* chore: Update to the latest version of yscope-dev-utils. (y-scope#574)

* build(core): Upgrade msgpack to v7.0.0. (y-scope#575)

* feat(ffi): Update IR stream protocol version handling in preparation for releasing the kv-pair IR stream format: (y-scope#573)

- Bump the IR stream protocol version to 0.1.0 for the kv-pair IR stream format.
- Treat the previous IR stream format's versions as backwards compatible.
- Differentiate between backwards-compatible and supported versions during validation.

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

* fix(taskfiles): Trim trailing slash from URL prefix in `download-and-extract-tar` (fixes y-scope#577). (y-scope#578)

* fix(ffi): Correct `clp::ffi::ir_stream::Deserializer::deserialize_next_ir_unit`'s return value when failing to read the next IR unit's type tag. (y-scope#579)

* fix(taskfiles): Update `yscope-log-viewer` sources in `log-viewer-webui-clients` sources list (fixes y-scope#576). (y-scope#580)

* fix(cmake): Add Homebrew path detection for `mariadb-connector-c` to fix macOS build failure. (y-scope#582)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

* refactor(ffi): Make `get_schema_subtree_bitmap` a public method of `KeyValuePairLogEvent`. (y-scope#581)

* ci: Schedule GitHub workflows to daily run to detect failures due to upgraded dependencies or environments. (y-scope#583)

* docs: Update the required version of task. (y-scope#567)

* Add pr check workflow

---------

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Co-authored-by: Junhao Liao <junhao.liao@yscope.com>
Co-authored-by: Henry8192 <50559854+Henry8192@users.noreply.github.com>
Co-authored-by: Devin Gibson <gibber9809@users.noreply.github.com>
Co-authored-by: wraymo <37269683+wraymo@users.noreply.github.com>
Co-authored-by: wraymo <raywangv@gmail.com>
Co-authored-by: Xiaochong(Eddy) Wei <40865608+anlowee@users.noreply.github.com>
Co-authored-by: Xiaochong Wei <xiaochong.wei@yscope.com>
Co-authored-by: haiqi96 <14502009+haiqi96@users.noreply.github.com>
@junhaoliao junhaoliao mentioned this pull request Nov 27, 2024
Closed
jackluo923 pushed a commit to jackluo923/clp that referenced this pull request Dec 4, 2024
@junhaoliao
log-viewer-webui: Update yscope-log-viewer to the latest version (w…
7159e21 
…hich uses `clp-ffi-js`). (y-scope#562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemarco davemarco davemarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junhaoliao @davemarco @kirkrodrigues