fix(taskfiles): Trim trailing slash from URL prefix in download-and-extract-tar (fixes #577).

[kirkrodrigues]

Description

As #577 describes, the extra slash in the nodejs download URL was causing the download to fail. This PR trims any trailing slash from the URL prefix passed to download-and-extract-ar to resolve the issue.

NOTE: We can't remove the trailing slash from NODEJS_VERSION_BASE_URL since that will prevent us from listing available files when computing NODEJS_FILE_BASE_NAME:

clp/Taskfile.yml

Lines 480 to 488 in 426cc3d

	NODEJS_VERSION_BASE_URL: "https://nodejs.org/dist/{{.NODEJS_VERSION}}/"
	NODEJS_FILE_BASE_NAME:
	sh: >-
	curl --header "Cache-Control: no-cache, no-store" --silent "{{.NODEJS_VERSION_BASE_URL}}"
	| grep
	--only-matching
	--max-count 1
	"node-v[[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+-{{OS}}-{{.NODEJS_ARCH}}"
	| head --lines 1

Validation performed

• task lint:js-check succeeds.
• The lint GH workflow succeeds.

Summary by CodeRabbit

• Chores
  • Improved URL handling in the download-and-extract-tar task by removing trailing slashes from the URL prefix.
  • Minor adjustments made to comments and formatting for clarity.

[coderabbitai]

Walkthrough

The changes in the Taskfile.yml focus on the download-and-extract-tar task, specifically modifying the curl command to eliminate any trailing slashes from the URL prefix. This is achieved through the use of the trimSuffix function. While there are minor formatting and comment adjustments, the overall structure and functionality of the tasks remain unchanged, ensuring that the build and cleanup processes continue to operate as intended.

Changes

File	Change Summary
Taskfile.yml	Modified curl command in download-and-extract-tar task to use trimSuffix for URL prefix, ensuring no trailing slashes. Minor comments and formatting adjustments made.

Possibly related issues

• download-and-extract-tar task inserts extra slash, causing some downloads to fail #577: The changes address the issue of an extra slash in the download-and-extract-tar task's URL, which was causing download failures. The modification ensures that the URL is correctly formatted, preventing the reported 404 error.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 426cc3d and 47e876d.

📒 Files selected for processing (1)

• Taskfile.yml (1 hunks)

🔇 Additional comments (1)

Taskfile.yml (1)

351-351: LGTM! The URL handling fix looks good.

The use of trimSuffix to remove trailing slashes from .URL_PREFIX before concatenating with .TAR_NAME is the correct approach. This ensures proper URL formation while maintaining the ability to list files when computing NODEJS_FILE_BASE_NAME.

Let's verify the URL formation in the dependent tasks:

✅ Verification successful

URL handling change is correctly implemented and safe

The verification confirms that:

• Only two tasks use URL_PREFIX: meteor and nodejs
• Both tasks properly use the download-and-extract-tar task
• The URL formation is consistent:
  • Meteor uses a static URL with version: https://static.meteor.com/packages-bootstrap/{{.METEOR_RELEASE}}
  • Node.js uses the base URL from nodejs.org: https://nodejs.org/dist/{{.NODEJS_VERSION}}/

The trimSuffix solution ensures correct URL concatenation without affecting the ability to list files in the Node.js task.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify URL formation in tasks that use download-and-extract-tar

# Test: Check URL_PREFIX usage in tasks. Expect: Only meteor and nodejs tasks.
rg -A 5 'URL_PREFIX:' Taskfile.yml

Length of output: 379

---

Script:

#!/bin/bash
# Let's verify the complete task definitions to understand the URL handling
rg -B 5 -A 10 'URL_PREFIX:' Taskfile.yml

# Also check if there are any other tasks using download-and-extract-tar
rg -B 2 'download-and-extract-tar' Taskfile.yml

Length of output: 1600

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.