Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-viewer-webui: Update yscope-log-viewer to the latest version. #565

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

kirkrodrigues
Copy link
Member

@kirkrodrigues kirkrodrigues commented Oct 26, 2024

Description

This updates to the latest version of the log viewer which includes some minor fixes and changes.

Validation performed

  1. sbin/start-clp.sh
  2. sbin/compress.sh hive-24hrs
  3. Opened the search UI at http://localhost:4000/search
  4. Searched for INFO
  5. Clicked on the file path in one of the search results.
  6. Validated that the log viewer was opened with the cursor at the same search result.
  7. Repeated steps 5-6 with another search result.
  8. Validated that the package could be built without the .git directory:
    • Cloned a fresh copy of the repo and branch.
    • rm -rf .git
    • tools/scripts/deps/init.sh
    • task
    • Repeated steps 1-7 with the built package.

Summary by CodeRabbit

  • Chores
    • Updated the commit reference for the log viewer component to enhance stability and performance.
    • Modified the source name and URL for the yscope-log-viewer dependency to ensure accurate downloads.

Copy link
Contributor

coderabbitai bot commented Oct 26, 2024

Walkthrough

The changes involve updating the commit reference for the yscope-log-viewer subproject within the components/log-viewer-webui directory. The previous commit hash has been replaced with a new hash, and the corresponding updates have been made to the deps-tasks.yml file, specifically altering the source name and URL for the dependency being downloaded.

Changes

File Path Change Summary
components/log-viewer-webui/yscope-log-viewer Subproject commit updated: bc8109f9f371c3327070000dee3537bdaf5354284c69bc11dbe8a5d87b5fbfb0e43a2f2a06f04866
deps-tasks.yml Updated SRC_NAME from yscope-log-viewer-bc8109f9f371c3327070000dee3537bdaf535428 to yscope-log-viewer-4c69bc11dbe8a5d87b5fbfb0e43a2f2a06f04866; updated SRC_URL from https://github.com/y-scope/yscope-log-viewer/archive/bc8109f.zip to https://github.com/y-scope/yscope-log-viewer/archive/4c69bc1.zip

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as Log Viewer
    participant C as Subproject

    A->>B: Request log data
    B->>C: Fetch data from commit `4c69bc11dbe8a5d87b5fbfb0e43a2f2a06f04866`
    C-->>B: Return log data
    B-->>A: Display log data
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a0efa06 and 66cfeed.

📒 Files selected for processing (1)
  • deps-tasks.yml (1 hunks)
🔇 Additional comments (1)
deps-tasks.yml (1)

424-425: LGTM! Verify the commit hash exists in the repository.

The source name and URL updates are consistent with the task's structure and other similar tasks in the file.

Let's verify the commit exists and is from the main branch:

✅ Verification successful

Commit hash verification successful

The commit 4c69bc11dbe8a5d87b5fbfb0e43a2f2a06f04866 exists in the y-scope/yscope-log-viewer repository and was merged via PR #106. The shortened hash 4c69bc1 in the URL correctly matches the full hash.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the commit hash exists in the yscope-log-viewer repository
# and is from the main branch

# Test: Check if the commit exists and is from main
gh api \
  -H "Accept: application/vnd.github+json" \
  repos/y-scope/yscope-log-viewer/commits/4c69bc11dbe8a5d87b5fbfb0e43a2f2a06f04866 \
  --jq '.sha as $sha | select($sha == "4c69bc11dbe8a5d87b5fbfb0e43a2f2a06f04866")'

Length of output: 6053


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@davemarco davemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in @junhaoliao PR he updated this as well?
Screenshot 2024-10-27 at 2 33 17 PM

@kirkrodrigues
Copy link
Member Author

Sorry, I forgot to update it.

@kirkrodrigues kirkrodrigues merged commit 829013b into y-scope:main Oct 28, 2024
18 checks passed
@kirkrodrigues kirkrodrigues deleted the update-ylv branch October 28, 2024 01:25
LinZhihao-723 added a commit to LinZhihao-723/clp that referenced this pull request Nov 12, 2024
* ffi: Add support for serializing/deserializing auto-generated and user-generated schema tree node IDs. (y-scope#557)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

* clp: Add missing C++ standard library includes in IR parsing files. (y-scope#561)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

* log-viewer-webui: Update `yscope-log-viewer` to the latest version (which uses `clp-ffi-js`). (y-scope#562)

* package: Upgrade dependencies to resolve security issues. (y-scope#536)

* clp-s: Implement table packing (y-scope#466)

Co-authored-by: wraymo <37269683+wraymo@users.noreply.github.com>
Co-authored-by: Kirk Rodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Co-authored-by: wraymo <raywangv@gmail.com>

* log-viewer-webui: Update `yscope-log-viewer` to the latest version. (y-scope#565)

* ci: Switch GitHub macOS build workflow to use macos-13 (x86) and macos-14 (ARM) runners. (y-scope#566)

* core: Add support for user-defined HTTP headers in `NetworkReader`. (y-scope#568)

Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com>
Co-authored-by: Xiaochong Wei <xiaochong.wei@yscope.com>

* chore: Update to the latest version of yscope-dev-utils. (y-scope#574)

* build(core): Upgrade msgpack to v7.0.0. (y-scope#575)

* feat(ffi): Update IR stream protocol version handling in preparation for releasing the kv-pair IR stream format: (y-scope#573)

- Bump the IR stream protocol version to 0.1.0 for the kv-pair IR stream format.
- Treat the previous IR stream format's versions as backwards compatible.
- Differentiate between backwards-compatible and supported versions during validation.

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

* fix(taskfiles): Trim trailing slash from URL prefix in `download-and-extract-tar` (fixes y-scope#577). (y-scope#578)

* fix(ffi): Correct `clp::ffi::ir_stream::Deserializer::deserialize_next_ir_unit`'s return value when failing to read the next IR unit's type tag. (y-scope#579)

* fix(taskfiles): Update `yscope-log-viewer` sources in `log-viewer-webui-clients` sources list (fixes y-scope#576). (y-scope#580)

* fix(cmake): Add Homebrew path detection for `mariadb-connector-c` to fix macOS build failure. (y-scope#582)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

* refactor(ffi): Make `get_schema_subtree_bitmap` a public method of `KeyValuePairLogEvent`. (y-scope#581)

* ci: Schedule GitHub workflows to daily run to detect failures due to upgraded dependencies or environments. (y-scope#583)

* docs: Update the required version of task. (y-scope#567)

* Add pr check workflow

---------

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Co-authored-by: Junhao Liao <junhao.liao@yscope.com>
Co-authored-by: Henry8192 <50559854+Henry8192@users.noreply.github.com>
Co-authored-by: Devin Gibson <gibber9809@users.noreply.github.com>
Co-authored-by: wraymo <37269683+wraymo@users.noreply.github.com>
Co-authored-by: wraymo <raywangv@gmail.com>
Co-authored-by: Xiaochong(Eddy) Wei <40865608+anlowee@users.noreply.github.com>
Co-authored-by: Xiaochong Wei <xiaochong.wei@yscope.com>
Co-authored-by: haiqi96 <14502009+haiqi96@users.noreply.github.com>
jackluo923 pushed a commit to jackluo923/clp that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants