Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Fix/Enhance with closure value implementation. #1758

Merged
merged 2 commits into from
Jun 3, 2018
Merged

[8.0] Fix/Enhance with closure value implementation. #1758

merged 2 commits into from
Jun 3, 2018

Conversation

yajra
Copy link
Owner

@yajra yajra commented Jun 3, 2018

Example

return datatables($query)
    ->setRowId('id')
    ->with('totalWeight', function($filteredQuery) {
        return $filteredQuery->sum('weight');
    })

PR REVERTED

See #1759 for new implementation since this may cause a breaking change.

yajra added 2 commits June 3, 2018 08:47
Use filteredQuery as callback parameter.
Fix #1752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant