Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] Add withQuery api for query callback. #1759

Merged
merged 2 commits into from
Jun 3, 2018
Merged

[8.0] Add withQuery api for query callback. #1759

merged 2 commits into from
Jun 3, 2018

Conversation

yajra
Copy link
Owner

@yajra yajra commented Jun 3, 2018

Revert #1758 with callback implementation since its BC.

return datatables($query)
    ->setRowId('id')
    ->withQuery('totalWeight', function($filteredQuery) {
        return $filteredQuery->sum('weight');
    })

@yajra
Add withQuery api for query callback.
66ab96c 
Revert with callback implementation since its BC.
@yajra yajra mentioned this pull request Jun 3, 2018
Merged
@yajra yajra mentioned this pull request Jun 3, 2018
Closed
@yajra yajra merged commit f927a74 into 8.0 Jun 3, 2018
@yajra yajra deleted the patch-with branch June 3, 2018 01:31
@yajra yajra added the need docs label Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement need docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yajra