Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adding VPN SG explicitly #4

Merged
merged 3 commits into from
Aug 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Enable adding VPN SG explicitly"
This reverts commit c9dae1d.
  • Loading branch information
ramesh-KSubramanian committed Aug 7, 2024
commit 34dbfa055e45fc7296caafb14fbabc1c5c4bf5ba
5 changes: 1 addition & 4 deletions main.tf
Original file line number Diff line number Diff line change
@@ -16,10 +16,7 @@ resource "aws_elasticache_replication_group" "redis" {
port = var.redis_port
parameter_group_name = aws_elasticache_parameter_group.redis_parameter_group.id
subnet_group_name = aws_elasticache_subnet_group.redis_subnet_group.id
security_group_names = var.security_group_names
security_group_ids = compact([aws_security_group.redis_security_group.id, var.enable_vpn_sg ? var.vpn_sg_id : ""])
snapshot_arns = var.snapshot_arns
snapshot_name = var.snapshot_name
security_group_ids = [aws_security_group.redis_security_group.id]
apply_immediately = var.apply_immediately
maintenance_window = var.redis_maintenance_window
snapshot_window = var.redis_snapshot_window
70 changes: 0 additions & 70 deletions variables.tf
Original file line number Diff line number Diff line change
@@ -121,73 +121,3 @@ variable "tags" {
type = map(string)
default = {}
}

variable "auto_minor_version_upgrade" {
description = "Specifies whether a minor engine upgrades will be applied automatically to the underlying Cache Cluster instances during the maintenance window"
type = bool
default = true
}

variable "availability_zones" {
description = "A list of EC2 availability zones in which the replication group's cache clusters will be created. The order of the availability zones in the list is not important"
type = list(string)
default = []
}

variable "at_rest_encryption_enabled" {
description = "Whether to enable encryption at rest"
type = bool
default = false
}

variable "kms_key_id" {
description = "The ARN of the key that you wish to use if encrypting at rest. If not supplied, uses service managed encryption. Can be specified only if at_rest_encryption_enabled = true"
type = string
default = ""
}

variable "transit_encryption_enabled" {
description = "Whether to enable encryption in transit. Requires 3.2.6 or >=4.0 redis_version"
type = bool
default = false
}

variable "auth_token" {
description = "The password used to access a password protected server. Can be specified only if transit_encryption_enabled = true. If specified must contain from 16 to 128 alphanumeric characters or symbols"
type = string
default = null
}

variable "security_group_names" {
description = "A list of cache security group names to associate with this replication group"
type = list(string)
default = []
}

variable "snapshot_arns" {
description = "A single-element string list containing an Amazon Resource Name (ARN) of a Redis RDB snapshot file stored in Amazon S3. Example: arn:aws:s3:::my_bucket/snapshot1.rdb"
type = list(string)
default = []
}

variable "snapshot_name" {
description = " The name of a snapshot from which to restore data into the new node group. Changing the snapshot_name forces a new resource"
type = string
default = ""
}

variable "notification_topic_arn" {
description = "An Amazon Resource Name (ARN) of an SNS topic to send ElastiCache notifications to. Example: arn:aws:sns:us-east-1:012345678999:my_sns_topic"
type = string
default = ""
}
variable "enable_vpn_sg" {
description = "Specifies whether to explicitly reference VPC SG for the Redis Instance"
type = bool
default = false
}
variable "vpn_sg_id" {
description = "VPC SG id to explicitly reference under Network & Security for the Redis Instance"
type = string
default = ""
}