[Bug]: HTTP urls do not support query parameters and do not support extensionless URLs #5929
Labels
Comments
This comment has been minimized.
This comment has been minimized.
yarnbot
added
reproducible
|
This issue reproduces on master: |
|
Duplicate of #2437, although this other thread is closed. We probably should improve the situation somehow. |
|
Will be fixed with #5931 |
arcanis
added a commit
that referenced
this issue
Nov 3, 2023
**What's the problem this PR addresses?** The v2 never supported referencing packages exposed as extensionless tgz tarballs, despite other clients being fine with them. Us being stricter here doesn't provide any value, and just hurts compatibility. Fixes #5929 **How did you fix it?** Adds support for extensionless urls, which are now interpreted as regular tarballs. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Self-service
Describe the bug
I am trying to add this tgz as a dependency: https://gitpkg.now.sh/acornjs/acorn/acorn?c3ec7023f08bdd6c4eee0bf76bfa2e0b88af8e4a
However, Yarn throws an error:
I also tried to remove the query parameter, and it still throws:
For the case without the query parameter, I can add
#.tgzat the end of the URL. This is meaningless (it's just a URL hash that the server ignores), but it makes Yarn happy: https://gitpkg.now.sh/acornjs/acorn/acorn#.tgzHowever, this hack does not work when there is a query parameter (https://gitpkg.now.sh/acornjs/acorn/acorn?c3ec7023f08bdd6c4eee0bf76bfa2e0b88af8e4a#.tgz).
To reproduce
Environment
System: OS: macOS 14.0 CPU: (8) arm64 Apple M2 Binaries: Node: 20.8.0 - /private/var/folders/bg/d5r9tspx5hn87zp52mcl82dh0000gn/T/xfs-1a04181c/node Yarn: 3.6.2 - /private/var/folders/bg/d5r9tspx5hn87zp52mcl82dh0000gn/T/xfs-1a04181c/yarn npm: 10.1.0 - /usr/local/bin/npm bun: 1.0.0 - ~/.bun/bin/bun npmPackages: jest: ^29.6.2 => 29.6.2 We couldn't upgrade to Yarn 4 yet, apologies if this has been already fixed :sweat_smile:Additional context
Regardless of the query parameter, URLs extensions are meaningless. I could serve a JS file at
http://example.com/foo.tar, or a tarball athttp://example.com/foo.js. On the web, the file type is described by the mime type in the HTTP response and not by the "extension".The text was updated successfully, but these errors were encountered: