Adds extensionless url support #5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
merceyz
reviewed
Nov 3, 2023
Comment on lines
+2
to
+3
| "@yarnpkg/cli": patch | ||
| "@yarnpkg/plugin-http": patch |
There was a problem hiding this comment.
Suggested change
| "@yarnpkg/cli": patch | |
| "@yarnpkg/plugin-http": patch | |
| "@yarnpkg/cli": minor | |
| "@yarnpkg/plugin-http": minor |
This is a new feature, no?
There was a problem hiding this comment.
There's a reasonable case that it's a compatibility bugfix. It could be seen as a feature as well, but I don't think it's matches the typical threshold for what's worth waiting for a minor release vs a patch one.
There was a problem hiding this comment.
waiting for a minor release
Don't wait, we should make releases whenever we feel like it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The v2 never supported referencing packages exposed as extensionless tgz tarballs, despite other clients being fine with them. Us being stricter here doesn't provide any value, and just hurts compatibility.
Fixes #5929
How did you fix it?
Adds support for extensionless urls, which are now interpreted as regular tarballs.
Checklist