Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It just suggested a version downgrade to me #181

Closed
papb opened this issue Jun 14, 2020 · 2 comments · Fixed by #192
Closed

It just suggested a version downgrade to me #181

papb opened this issue Jun 14, 2020 · 2 comments · Fixed by #192

Comments

@papb
Copy link

papb commented Jun 14, 2020

Screenshot:

image

As text:

$ npx xo --fix


   ╭───────────────────────────────────────╮
   │                                       │
   │   Update available 0.32.0 → 0.30.0    │
   │        Run npm i xo to update         │
   │                                       │
   ╰───────────────────────────────────────╯

What is happening? 😅

@yang
Copy link

yang commented Aug 19, 2020

We also see this:

image

   ╭───────────────────────────────────────────────────╮
   │                                                   │
   │         Update available 0.1.53 → 0.1.51          │
   │   Run yarn global add @plasmicapp/cli to update   │
   │                                                   │
   ╰───────────────────────────────────────────────────╯

@sindresorhus Perhaps due to this line comparing by equality?

if (!process.stdout.isTTY || suppressForNpm || !this.update || this.update.current === this.update.latest) {

@sindresorhus
Copy link
Member

Perhaps due to this line comparing by equality?

I don't think that's the underlying reason for it, but it seems like a good workaround for the issue. Just use https://github.com/npm/node-semver to ensure the version is newer.

kmcnellis added a commit to firebase/firebase-tools that referenced this issue Apr 16, 2021
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
kmcnellis added a commit to firebase/firebase-tools that referenced this issue Apr 16, 2021
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
kmcnellis added a commit to firebase/firebase-tools that referenced this issue Apr 16, 2021
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
kmcnellis added a commit to firebase/firebase-tools that referenced this issue Apr 19, 2021
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this issue Dec 14, 2021
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants