-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't suggest to upgrade to lower version #192
Conversation
Not sure, but I don't think so, since I've seen this problem happen on non-beta versions too. |
Yeah the 2 comments were unrelated. I think latest-version could return a version older than its supposed to, I don’t know what else could be happening. Is it still cached here? |
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
Older verions of update-notifier suggested updating to older versions. See yeoman/update-notifier#192
Hi, Not sure it's related but we got those messages reported here: Any idea what could be happening? |
Looks like this bug is caused by the async nature of this package: fetch the update, and only notify about it on the 2nd run. As I have my own code to notify users, I think I should just backport your logic to my own notifier. Wouldn't it make sense to somehow "erase" this.update data if on 2nd run we detech packageVersion is > latest fetched version? This could fix the issue in a more generic way? |
Update to a version that includes yeoman/update-notifier#192 to avoid the bug where it will suggest downgrading your version (yeoman/update-notifier#181).
Looks like this is a bug in update-notifier, but they [smoothed it over](yeoman/update-notifier#192) with a change that was deployed in [`5.0.0`](https://github.com/yeoman/update-notifier/releases/tag/v5.0.0). We’re currently on `4.1.0`. This can cause an update notification for a PREVIOUS version, like so: ``` $ vc --version > UPDATE AVAILABLE Run `npm i -g vercel@latest` to install Vercel CLI 24.2.5-canary.3 > Changelog: https://github.com/vercel/vercel/releases/tag/vercel@24.2.5-canary.3 Vercel CLI 24.2.5 24.2.5 ``` While we're here, also sets the [`updatecheckinterval`](https://github.com/yeoman/update-notifier#updatecheckinterval) to 1 week. --- Previous PR: #4896
Fixes #181
I haven't investigated why this would happen in the first place, but I guess it could if you install a beta version.
Is that a bug in https://github.com/sindresorhus/latest-version?