LRS-61 Remove Error Interceptor

[milt]

LET MY PEOPLE THROW (Kinda)

Exception handling should be delegated to implementations based on their needs regarding logging, security, etc.

We were applying an error handling interceptor erroneously to all the routes but doc, this has been changed (see below)

We also included errors in the return spec for sync lrs methods, but did not catch and ensure these were included for the lib handling to use. Catching and passing of errors has been standardized across all sync method wrappers in lrs.cljc with the exception of consistent-through, which is called by an interceptor and functions differently.

Any error that is not explicitly handled by the lrs layer (a narrow class of specific named errors) will now be properly placed in the pedestal context map. Implementations can apply any error handling they wish by providing an error interceptor in the :wrap-interceptors vector passed to routes/build.

UPDATE: The default for the :wrap-interceptors vector is now [i/error-interceptor] per @kelvinqian00's request, meaning the default behavior will not change for implementations, though it will now also apply to doc routes which it did not before.

• remove error interceptor from common interceptors
• add :wrap-interceptors arg to routs build for passing your own global interceptors
• make return less weird for implementations that want to use it
• ensure handler fns are properly passing thrown impl errors and not covering what should be 500s

[milt]

demonstrates plugging in your own

[kelvinqian00]

Going to hold off on approval until this bug is addressed:

Wowww. I’ve confirmed that w/o the error handler cljs also just up and dies, but oddly it also does with the handler, lol. Gonna re-check the handler for cljs compat, just in case
Yeah, that looks like a separate bug in the terminator-injector and not something that started with my branch

[kelvinqian00]

Misunderstood the implications of the above revelation (i.e. the two issues are not connected); otherwise this looks great.