Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL-125] Redact sensitive information from traces #189

Merged
merged 10 commits into from
Dec 14, 2021
Merged

[SQL-125] Redact sensitive information from traces #189

merged 10 commits into from
Dec 14, 2021

Conversation

kelvinqian00
Copy link
Collaborator

@kelvinqian00 kelvinqian00 commented Dec 10, 2021 •
edited
Loading

  • Redact sensitive info before logging config var maps
  • Turn off Pedestal logging since we can't redact info from that (Made redundant by LRS-61 Remove Error Interceptor lrs#71)
  • Return 400 instead of 500 error (which spews out exn info) upon JSONParseException
  • TODO: Write tests for the above Done!

milt
milt approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible enough to me

cliffcaseyyet
cliffcaseyyet approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@cliffcaseyyet cliffcaseyyet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kelvinqian00 kelvinqian00 marked this pull request as draft December 10, 2021 20:25
@kelvinqian00 kelvinqian00 marked this pull request as ready for review December 13, 2021 19:24
milt
milt approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good. As expected the json parse catcher after the general error handler will get called before it on the exit interceptor pass.

@kelvinqian00 kelvinqian00 merged commit dafeeeb into main Dec 14, 2021
@kelvinqian00 kelvinqian00 deleted the redact_traces branch December 14, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffcaseyyet cliffcaseyyet cliffcaseyyet approved these changes

@milt milt milt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinqian00 @milt @cliffcaseyyet