Skip to content

Commit

Permalink
Upgrade Jest to v29 (#309)
Browse files Browse the repository at this point in the history
Upgrade Jest from v27 to v29. We had [previously](#169) upgraded Jest to v28, but had to [downgrade](#275) to v27 because at the time, `@storybook/test-runner` only supported up to v27. In v0.7 of `@storybook/test-runner`, they changed Jest to be an internal dependency instead of a peer dependency, allowing us to use whatever version of Jest we want.

There was only one breaking change in v29 that affected our code, besides those that already needed to be made when upgrading from v27 to v28 (see previous PR [description](#169 (comment))). This was the `jsdom` upgrade from v19 to v20 in `jest-environment-jsdom`, which requires the `typescript` version to be 4.5 or higher.

With the new support added in v29 and `uuid` v9, we are now able to remove the manual resolving needed in `tests/__setup__/resolver.ts`. For more context on why this was initially needed with Jest v28, see #169.

J=SLAP-2376
TEST=manual

See that existing tests still run properly.
  • Loading branch information
nmanu1 authored Sep 30, 2022
1 parent b2e41f2 commit ae97885
Show file tree
Hide file tree
Showing 5 changed files with 37,994 additions and 28,028 deletions.
45 changes: 37 additions & 8 deletions THIRD-PARTY-NOTICES
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
The following NPM packages may be included in this product:

- @babel/code-frame@7.16.7
- @babel/helper-validator-identifier@7.16.7
- @babel/highlight@7.16.10
- @babel/code-frame@7.18.6
- @babel/helper-validator-identifier@7.19.1
- @babel/highlight@7.18.6
- @babel/runtime-corejs3@7.17.2
- @babel/runtime@7.18.9

Expand Down Expand Up @@ -1277,7 +1277,7 @@ THE SOFTWARE.

The following NPM package may be included in this product:

- browserslist@4.20.2
- browserslist@4.21.4

This package contains the following license and notice below:

Expand Down Expand Up @@ -1336,7 +1336,7 @@ THE SOFTWARE.

The following NPM package may be included in this product:

- caniuse-lite@1.0.30001322
- caniuse-lite@1.0.30001414

This package contains the following license and notice below:

Expand Down Expand Up @@ -2256,7 +2256,7 @@ SOFTWARE.

The following NPM package may be included in this product:

- electron-to-chromium@1.4.99
- electron-to-chromium@1.4.268

This package contains the following license and notice below:

Expand Down Expand Up @@ -3591,7 +3591,7 @@ SOFTWARE.

The following NPM package may be included in this product:

- node-releases@2.0.2
- node-releases@2.0.6

This package contains the following license and notice below:

Expand Down Expand Up @@ -4801,6 +4801,35 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----------

The following NPM package may be included in this product:

- update-browserslist-db@1.0.9

This package contains the following license and notice below:

The MIT License (MIT)

Copyright 2022 Andrey Sitnik <andrey@sitnik.ru> and other contributors

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----------

The following NPM package may be included in this product:

- uri-js@4.4.1
Expand Down Expand Up @@ -4886,7 +4915,7 @@ OTHER DEALINGS IN THE SOFTWARE.

The following NPM package may be included in this product:

- uuid@8.3.2
- uuid@9.0.0

This package contains the following license and notice below:

Expand Down
Loading

0 comments on commit ae97885

Please sign in to comment.