Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jest to v29 #309

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Upgrade Jest to v29 #309

merged 1 commit into from
Sep 30, 2022

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Sep 29, 2022

Upgrade Jest from v27 to v29. We had previously upgraded Jest to v28, but had to downgrade to v27 because at the time, @storybook/test-runner only supported up to v27. In v0.7 of @storybook/test-runner, they changed Jest to be an internal dependency instead of a peer dependency, allowing us to use whatever version of Jest we want.

There was only one breaking change in v29 that affected our code, besides those that already needed to be made when upgrading from v27 to v28 (see previous PR description). This was the jsdom upgrade from v19 to v20 in jest-environment-jsdom, which requires the typescript version to be 4.5 or higher.

With the new support added in v29 and uuid v9, we are now able to remove the manual resolving needed in tests/__setup__/resolver.ts. For more context on why this was initially needed with Jest v28, see #169.

J=SLAP-2376
TEST=manual

See that existing tests still run properly.

@nmanu1 nmanu1 requested a review from a team as a code owner September 29, 2022 21:17
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.356% when pulling e1fdf59 on dev/jest-v29 into b2e41f2 on develop.

@github-actions
Copy link
Contributor

Current unit coverage is 88.49693251533742%
Current visual coverage is 77.40899357601712%
Current combined coverage is 89.03374233128834%

package.json Show resolved Hide resolved
@nmanu1 nmanu1 merged commit ae97885 into develop Sep 30, 2022
@nmanu1 nmanu1 deleted the dev/jest-v29 branch September 30, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants