-
-
Notifications
You must be signed in to change notification settings - Fork 879
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
10 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9973982
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atusy Does this change look okay to you?
9973982
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yihui Yes. This is much much better! Thank you!!
9973982
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Perhaps you can collect these examples, and someday write a book titled "Writing Shorter R Code (with A Thousand Practical Examples)" :)
9973982
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL
Sorry, I found a bug with your refactoring.
find_chrome
is implemented by chromote, not by webshot2.This means the function always catches the error.
9973982#diff-cebed083352aaa9f9cf564e06b3e28047ff8da73972705e9e64bd69d8e999478L529
9973982
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch! Amended in d83e8de. Thanks!
BTW, the book should be titled "Writing Shorter But Buggy R Code" now...