-
-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer webshot2 to webshot and solve #1858 #1918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just one small question. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I'll carry on from here and merge in a few minutes. Thank you!
I forgot to mention that another possible idea is to use |
The function are a bit different in their way to find chrome, and specifically with the env var mechanism which is not the same env var. They both will find chrome but there could be a mismatch of version if you have several locally, as webshot2 will use the one that chromote will use. I would stick to the one in chromote for now, and maybe ask them to put one in webshot2 as a helper to test availability of chrome for other package ? or better that they do the check themselves maybe. |
|
With this PR, html_screenshot` tries to use webshot2 and fallbacks to webshot.
Also, user may prioritize webshot by
opts_chunk$set(webshot = "webshot")
.Another possibility is to use
opts_knit$set(webshot = "webshot")
.I'm fine with both ways, but choose the
opts_chunk
because it has controlls on each chunks.