Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprites walls. II #22813

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grimm-hollowknight
Copy link
Contributor

Document the changes in your pull request

Resprites the walls as per a commission.

The bare minimum has been committed to allow these to be testmerged.

Some additional changes are planned as long as they can be feasibly implemented by myself. A bullet point list will detail some planned changes. The tiled pattern (walls joined together that take up at least 2 tiles of thickness.) are still being worked on as they look unpleasant.

Why is this good for the game?

The current walls are venerable and work in their own way but new walls may be able to freshen up the server visually.

Testing

I daemon'd, I saw, I PRed.

Spriting

Compared to the previous PR, these are near final implementation. Feedback is still welcome.

While initial impressions were positive, if you do not like them please remain respectful. Some may be annoyed to hear this but: if possible, please take some time to get used to it before writing them off.

IMAGES

MED
arrival
kitchen
lib
GENE
EVA
central
(vv WORK IN PROGRESS vv)
AI

Planned changes (So far)

  • Shift position of wall items

  • Update tiled sections

  • Implement divisions (Lines between junctions)

  • ???

(idk how these lists work but it looks cool)

Wiki Documentation

All images of the map would need to be updated.

Changelog

🆑 Identification
imageadd: Updated walls.
/:cl:

@grimm-hollowknight grimm-hollowknight requested a review from a team as a code owner November 18, 2024 01:05
@Yogbot-13 Yogbot-13 added the Sprites This PR has spriting changes label Nov 18, 2024
@AMyriad AMyriad added DO NOT MERGE Should not be merged without express approval from a Head Dev Literally the best PR My god its beautiful Awaiting - Action - Sprite Review Awaiting sprite review from sprite maintainers labels Nov 18, 2024
@Mantlecrawler
Copy link
Contributor

the wallening if it was actually good

@JamieD1
Copy link
Contributor

JamieD1 commented Dec 1, 2024

I think it would be better if you showed some pictures of walls without birds eye view, as in from one side of the wall to see how it looks. Looking at it from birds eye looks like they are not flat. Can you provide a few pictures?

Yogbot-13 added a commit that referenced this pull request Dec 4, 2024
Yogbot-13 added a commit that referenced this pull request Dec 4, 2024
Yogbot-13 added a commit that referenced this pull request Dec 5, 2024
Yogbot-13 added a commit that referenced this pull request Dec 6, 2024
Yogbot-13 added a commit that referenced this pull request Dec 8, 2024
Yogbot-13 added a commit that referenced this pull request Dec 11, 2024
Yogbot-13 added a commit that referenced this pull request Dec 12, 2024
Yogbot-13 added a commit that referenced this pull request Dec 12, 2024
Yogbot-13 added a commit that referenced this pull request Dec 13, 2024
Yogbot-13 added a commit that referenced this pull request Dec 22, 2024
Yogbot-13 added a commit that referenced this pull request Dec 25, 2024
Yogbot-13 added a commit that referenced this pull request Dec 29, 2024
Yogbot-13 added a commit that referenced this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Sprite Review Awaiting sprite review from sprite maintainers DO NOT MERGE Should not be merged without express approval from a Head Dev Literally the best PR My god its beautiful Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants