-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resprites walls. II #22813
Open
grimm-hollowknight
wants to merge
3
commits into
yogstation13:master
Choose a base branch
from
grimm-hollowknight:NewWalls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Resprites walls. II #22813
grimm-hollowknight
wants to merge
3
commits into
yogstation13:master
from
grimm-hollowknight:NewWalls
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynot01
approved these changes
Nov 18, 2024
AMyriad
added
DO NOT MERGE
Should not be merged without express approval from a Head Dev
Literally the best PR
My god its beautiful
Awaiting - Action - Sprite Review
Awaiting sprite review from sprite maintainers
labels
Nov 18, 2024
the wallening if it was actually good |
I think it would be better if you showed some pictures of walls without birds eye view, as in from one side of the wall to see how it looks. Looking at it from birds eye looks like they are not flat. Can you provide a few pictures? |
Yogbot-13
added a commit
that referenced
this pull request
Dec 4, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 4, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 5, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 6, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 8, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 11, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 12, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 12, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 13, 2024
This was referenced Dec 19, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 22, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 25, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 29, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 29, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 30, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 30, 2024
This was referenced Dec 31, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Awaiting - Action - Sprite Review
Awaiting sprite review from sprite maintainers
DO NOT MERGE
Should not be merged without express approval from a Head Dev
Literally the best PR
My god its beautiful
Sprites
This PR has spriting changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Resprites the walls as per a commission.
The bare minimum has been committed to allow these to be testmerged.
Some additional changes are planned as long as they can be feasibly implemented by myself. A bullet point list will detail some planned changes. The tiled pattern (walls joined together that take up at least 2 tiles of thickness.) are still being worked on as they look unpleasant.
Why is this good for the game?
The current walls are venerable and work in their own way but new walls may be able to freshen up the server visually.
Testing
I daemon'd, I saw, I PRed.
Spriting
Compared to the previous PR, these are near final implementation. Feedback is still welcome.
While initial impressions were positive, if you do not like them please remain respectful. Some may be annoyed to hear this but: if possible, please take some time to get used to it before writing them off.
IMAGES
(vv WORK IN PROGRESS vv)
Planned changes (So far)
Shift position of wall items
Update tiled sections
Implement divisions (Lines between junctions)
???
(idk how these lists work but it looks cool)
Wiki Documentation
All images of the map would need to be updated.
Changelog
🆑 Identification
imageadd: Updated walls.
/:cl: