Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Display additional users in a popover when there are more than 4 users #241

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

KimKyuHoi
Copy link
Contributor

@KimKyuHoi KimKyuHoi commented Jul 20, 2024

What this PR does / why we need it?

This PR enhances the user experience by implementing a feature that displays additional users in a popover when there are more than 4 users displayed.

Any background context you want to provide?

Currently, when there are more than 4 users to be displayed, the UI becomes cluttered. To address this issue, this PR introduces a popover functionality that shows the remaining users when there are more than 4 present, providing a cleaner and more organized interface.

What are the relevant tickets?

Fixes #139

Checklist

  • Added relevant tests or not required
  • Didn't break anything

A bit more information would be helpful to complete the PR.

Summary by CodeRabbit

  • New Features

    • Introduced a popover to display additional users when more than four are present, enhancing user interaction and interface clarity.
  • Improvements

    • Enhanced the user presence visualization by integrating new elements from Material-UI, providing a cleaner and more informative experience.

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

coderabbitai bot commented Jul 20, 2024

Walkthrough

The recent updates to the DocumentHeader component enhance user interaction by introducing a popover for displaying additional users when more than four are present. Utilizing Material-UI components, the implementation allows users to view hidden avatars in a streamlined manner, improving the overall clarity and engagement of the user presence feature.

Changes

Files Change Summary
frontend/src/components/headers/DocumentHeader.tsx Added functionality for a popover to show additional user avatars. Introduced state management for the popover, including open/close handlers, enhancing user experience by displaying hidden users in a clear format.

Poem

In the header where users meet,
A popover dances, oh so sweet!
Four friends in view, and more to share,
Click to see who’s lurking there!
With avatars bright, the interface shines,
A joyful update, where presence aligns! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KimKyuHoi KimKyuHoi changed the title Add Display additional users in a popover when there are more than 4 … Add Display additional users in a popover when there are more than 4 users Jul 20, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e1cebe0 and 0a74d32.

Files selected for processing (1)
  • frontend/src/components/headers/DocumentHeader.tsx (6 hunks)
Additional comments not posted (4)
frontend/src/components/headers/DocumentHeader.tsx (4)

12-17: New imports for popover functionality.

The new imports from Material-UI are necessary for the popover feature.


53-53: New state variable for popover anchor element.

The state variable anchorEl is correctly initialized with useState<HTMLElement | null>(null).


99-106: Popover handler functions.

The handler functions handleOpenPopover and handleClosePopover correctly manage the popover's anchor element.


Line range hint 152-200:
Popover rendering logic.

The popover rendering logic is correctly implemented, and the hiddenAvatars variable correctly slices the presence list to get the additional users.

Copy link
Member

@devleejb devleejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@devleejb devleejb merged commit cd36e26 into yorkie-team:main Jul 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Display names of all participants when showing presence with 4 or more members
3 participants