Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Display additional users in a popover when there are more than 4 users #241

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Add Display additional users in a popover when there are more than 4 users #241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1198371
Add Display additional users in a popover when there are more than 4 …
KimKyuHoi Jul 20, 2024
0a74d32
Fix Grid to List Item
KimKyuHoi Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 61 additions & 2 deletions frontend/src/components/headers/DocumentHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ import {
ToggleButtonGroup,
Toolbar,
Tooltip,
Popover,
Typography,
List,
ListItem,
ListItemAvatar,
ListItemText,
} from "@mui/material";
import EditIcon from "@mui/icons-material/Edit";
import VerticalSplitIcon from "@mui/icons-material/VerticalSplit";
Expand All @@ -17,7 +23,7 @@ import { useDispatch, useSelector } from "react-redux";
import { EditorModeType, selectEditor, setMode } from "../../store/editorSlice";
import ThemeButton from "../common/ThemeButton";
import ShareButton from "../common/ShareButton";
import { useEffect } from "react";
import { useEffect, useState } from "react";
import { useList } from "react-use";
import { ActorID } from "yorkie-js-sdk";
import { YorkieCodeMirrorPresenceType } from "../../utils/yorkie/yorkieSync";
Expand All @@ -44,6 +50,8 @@ function DocumentHeader() {
presence: YorkieCodeMirrorPresenceType;
}>([]);

const [anchorEl, setAnchorEl] = useState<HTMLElement | null>(null);

useEffect(() => {
if (editorState.shareRole === "READ") {
dispatch(setMode("read"));
Expand Down Expand Up @@ -87,6 +95,20 @@ function DocumentHeader() {
navigate(`/${workspaceState.data?.slug}`);
};

// Display additional users in a popover when there are more than 4 users
const handleOpenPopover = (event: React.MouseEvent<HTMLElement>) => {
setAnchorEl(event.currentTarget);
};

// Display None additional users in a popover when there are more than 4 users
const handleClosePopover = () => {
setAnchorEl(null);
};

const popoverOpen = Boolean(anchorEl);

const hiddenAvatars = presenceList.slice(3);

return (
<AppBar position="static" sx={{ zIndex: 100 }}>
<Toolbar>
Expand Down Expand Up @@ -127,7 +149,7 @@ function DocumentHeader() {
</Paper>
</Stack>
<Stack direction="row" alignItems="center" gap={1}>
<AvatarGroup max={4}>
<AvatarGroup max={4} onClick={handleOpenPopover}>
{presenceList?.map((presence) => (
<Tooltip key={presence.clientID} title={presence.presence.name}>
<Avatar
Expand All @@ -139,6 +161,43 @@ function DocumentHeader() {
</Tooltip>
))}
</AvatarGroup>
<Popover
open={popoverOpen}
anchorEl={anchorEl}
onClose={handleClosePopover}
anchorOrigin={{
vertical: "bottom",
horizontal: "left",
}}
>
<Paper sx={{ padding: 2 }}>
<Typography variant="subtitle2">Additional Users</Typography>
<List>
{hiddenAvatars.map((presence) => (
<ListItem key={presence.clientID} sx={{ paddingY: 0.5 }}>
<ListItemAvatar>
<Avatar
sx={{
bgcolor: presence.presence.color,
width: 24,
height: 24,
fontSize: 12,
}}
>
{presence.presence.name[0]}
</Avatar>
</ListItemAvatar>
<ListItemText
primary={presence.presence.name}
primaryTypographyProps={{
variant: "body2",
}}
/>
</ListItem>
))}
</List>
</Paper>
</Popover>
{!editorState.shareRole && <ShareButton />}
<ThemeButton />
</Stack>
Expand Down