Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide autocomplete on scroll in Firefox #438

Closed
jpic opened this issue Jun 1, 2015 · 9 comments
Closed

Do not hide autocomplete on scroll in Firefox #438

jpic opened this issue Jun 1, 2015 · 9 comments
Milestone

Comments

@jpic
Copy link
Member

jpic commented Jun 1, 2015

Last issue from #431: it has been reported that scrolling with an open autocomplete doesn't work well in windows.

Good news is that I contact BrowserStack support and they said they'd enable our tests on their awesome infra for free ... Because guess what: I don't have Windows so I can't reproduce ^^

@krikunts
Copy link
Member

krikunts commented Jun 1, 2015

Ok, I did some tests with rc8. The problem not just in Windows but in Firefox.
I have Firefox 37.0.1 on Linux Mint, 38.0.1 on Windows 7 and 38.0.1 on Android 4.3 and they all act the same way. If window height is small and we use my favourite bootstrap modal dialog scrolling down before typing breaks choices positioning. So the steps are:

  1. Open bootstrap modal dialog
  2. Scroll down to the input
  3. Start typing
    The choices are rendered above the input.

@jpic
Copy link
Member Author

jpic commented Jun 1, 2015

I see, you've got to scroll first before you open the AC and you can see the bug.

@jpic
Copy link
Member Author

jpic commented Jun 1, 2015

It seems like this happens on Firefox but not chrome, could you confirm
that ?

Since I can reproduce it I ll be able to show it to a front-end dev and if
there is not proper fix then we'll leave both positioning methods in 2.2.0.
Le 1 juin 2015 10:12, "Tatiana" notifications@github.com a écrit :

Ok, I did some tests with rc8. The problem not just in Windows but in
Firefox.
I have Firefox 37.0.1 on Linux Mint, 38.0.1 on Windows 7 and 38.0.1 on
Android 4.3 and they all act the same way. If window height is small and we
use my favourite bootstrap modal dialog scrolling down before typing
breaks choices positioning. So the steps are:

  1. Open bootstrap modal dialog
  2. Scroll down to the input
  3. Start typing
    The choices are rendered above the input.


Reply to this email directly or view it on GitHub
#438 (comment)
.

@krikunts
Copy link
Member

krikunts commented Jun 1, 2015

Yes, it's just Firefox. Chrome, Opera and IE don't have this issue AFAIK.

@jpic jpic changed the title Scrolling bug in Windows Scrolling bug in Firefox Jun 2, 2015
@jpic
Copy link
Member Author

jpic commented Jun 2, 2015

Ok, the purpose of having scroll working was for small devices, which are mostly under webkit or ie. Firefox being AFAIK mostly used on desktops, scroll support isn't bloquant.

So I'm going to hide the autocomplete on scroll on firefox and release 2.2.0 today. One of my roommates at djangocon said he'll help fixing that but that "this bug sucks so I'm going to really have to take time", so we'll hopefully have that fixed in 2.2.1.

Does that sound ok to you ?

@krikunts
Copy link
Member

krikunts commented Jun 2, 2015

I think this issue can wait till 2.2.1 for sure and I'll be glad if someone will fix that. Please let me know when there are any changes so I can help with testing.

jpic added a commit that referenced this issue Jun 2, 2015
jpic added a commit that referenced this issue Jun 2, 2015
@jpic jpic reopened this Jun 2, 2015
@jpic jpic added this to the 2.3.0 milestone Jun 2, 2015
@jpic jpic changed the title Scrolling bug in Firefox Do not hide autocomplete on scroll in Firefox Jun 2, 2015
@jpic
Copy link
Member Author

jpic commented Jun 6, 2015

I've been told by a Mozilla employee that we should report it on their bug tracker anyway because it's firefox-specific. Pretty awesome B)

@jpic
Copy link
Member Author

jpic commented Nov 21, 2015

The solution we've had works well enough. Please reopen if you have any question.

@jpic jpic closed this as completed Nov 21, 2015
@SummerSeaSun
Copy link

Hi,
we're experiencing the same problem, can you please post the firefox bug tracker reference?
It works even right even with Edge, is there any chance to get it working on Firefox?
Thanks, BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants