-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absolute positioning and resize #431
Comments
So it should be fine if we call fixPosition on browser scroll or resize ? It's a bit annoying I recon, but we've got to go through that to have sufficient material to convince the django dev community that the admin should move from overflow: hidden to using .clearfix to clear floats. |
BTW could you make a PR for your example if you'd like to help us support this on the long run ? |
I think it could work but can't say for sure, as I don't understand your event handling quite right to do it. |
Could you try with 2.2.0rc5 please ? Thanks ! |
2.2.0rc5 works ok with modal dialog but it breaks with common autocomplete input because it sets this.container equals to autocomplete input itself |
Oops ! How do you suggest we improve that ? After all, we could just let
|
Sorry, I didn't notice that with modal 2.2.0rc5 choices don't respond to resizes and scrolls just like before, so it doesn't help at all. |
What browsers do you have that won't make the input loose focus, causing For scrolling, I think it's a lot better to just start from the right About that other way, there should be a branch in my fork with an example, If we can't find a right way to support this then it would make sense to
|
I have Firefox 37.0.1 and Chromium 41.0.2272.76 on Linux Mint 17. |
On Fri, May 29, 2015 at 6:40 PM, Tatiana notifications@github.com wrote:
It seemed better to let scrolling work naturally in case the user is on a |
Note that I found this.container to be empty in django admin, not equal to this.input. I wonder how you got this.container to be equal to this.input, since this.container gets calculated depending on a traversal of this.input.parents(), could you double check please ? 2.2.0rc6 fixes django admin support with 5f744a9, simply by defaulting to Could you try 2.2.0rc6 and let me know if it fixes all your open issues or if there's still a problem. Thanks a lot for your help, really appreciated B) |
Oops, this was closed by mistake. Try 2.2.0rc7 please, I had forgotten the resize fix in 2.2.0rc6 ^^ Thanks a heap, I think we're good to go now B) |
I moved from my Linux at work to Windows home machine and testing on it. For rc7 everything is ok except for scroll in modal dialog (maybe it's just for Windows). Resize part is working great now. |
Unfortunately I won't see my CSS friends before the 15th so if anybody Thanks a heap for your time
|
Could you tell what browser version you tested it with in windows ? In issue #438 please which is the followup. |
This issue is related to the choices positioning and adaptive design (like Bootstrap).
Because of absolute positioning, introduced in 61e54ee the choices are not properly rendered.
If you resize the browser or scroll window while displaying choices all the elements change their positions but choices don't.
The text was updated successfully, but these errors were encountered: