Dynamic evaluation of the autocomp box container. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2.2.0 series, we want most complete support of Django admin - which means all edge cases - and it's oldschool overflow: hidden way of clearing floats. On the other hand, we also want top-notch support for modern CSS patterns such as the .clearfix which is the most-standard way of clearing floats IMHO and is of course the way all modern CSS frameworks clear their floats. By default, this traverses this.input's parents to find the nearest parent with an 'absolute' or 'fixed' position. This prevents scrolling issues that we'd have by boldly using <body>.
jpic
added a commit
that referenced
this pull request
May 29, 2015
Dynamic evaluation of the autocomp box container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.2.0 series, we want most complete support of Django admin - which means
all edge cases - and it's oldschool overflow: hidden way of clearing floats.
On the other hand, we also want top-notch support for modern CSS patterns such
as the .clearfix which is the most-standard way of clearing floats IMHO and is
of course the way all modern CSS frameworks clear their floats.
By default, this traverses this.input's parents to find the nearest parent
with an 'absolute' or 'fixed' position. This prevents scrolling issues that
we'd have by boldly using .