Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: xrender: set created picture to repeat when binding a pixmap #1000

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

absolutelynothelix
Copy link
Collaborator

@absolutelynothelix absolutelynothelix commented Jan 19, 2023

set created picture to repeat when binding a pixmap in the xrender backend. see #1002 for gl-powered backends.

related issue: #970

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1000 (ecbc8b5) into next (5e22434) will increase coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1000      +/-   ##
==========================================
+ Coverage   37.51%   37.66%   +0.14%     
==========================================
  Files          49       49              
  Lines       11171    11171              
==========================================
+ Hits         4191     4207      +16     
+ Misses       6980     6964      -16     
Impacted Files Coverage Δ
src/backend/xrender/xrender.c 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@absolutelynothelix
Copy link
Collaborator Author

absolutelynothelix commented Jan 19, 2023

@tryone144, do you have an idea how to implement this in gl-powered backends? i assume that we're supposed to use the effective width and height of the texture we're using in the gl_compose function because they're completely unused now.

@tryone144
Copy link
Collaborator

tryone144 commented Jan 19, 2023

Let me take a look at it. I am pretty sure the gl backends don't make use of the effective width and hight when composing...

Edit: Let me try something, this isn't the real issue here...
Edit2: Found the issue. Rounded corners don't play nice with smaller textures than effective size...

@tryone144
Copy link
Collaborator

The rounded corner calculation in the window shader broke this for opengl... See #1002 for the fix.

@absolutelynothelix
Copy link
Collaborator Author

absolutelynothelix commented Jan 20, 2023

@tryone144, nice, thank you! i don't think that i could figure this out myself.

@absolutelynothelix absolutelynothelix changed the title backend: xrender: set texture on repeat backend: xrender: set created picture to repeat when binding a pixmap Jun 16, 2023
@yshui yshui merged commit 01bb260 into yshui:next Jun 16, 2023
@absolutelynothelix absolutelynothelix deleted the set-texture-on-repeat branch June 18, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants