backend: gl: Use effective texture size for rounded corner calculation #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tryone144
force-pushed
the
fix/use-effective-texture-size-for-corner-radius
branch
from
8ccd10e
to
abbff8a
Compare
Codecov Report
@@ Coverage Diff @@
## next #1002 +/- ##
==========================================
- Coverage 37.82% 37.67% -0.16%
==========================================
Files 48 48
Lines 10849 10853 +4
==========================================
- Hits 4104 4089 -15
- Misses 6745 6764 +19
|
The rounded corner calculation only took the actual texture dimensions into account, effectively turning all pixels outside completely transparent. Furthermore, `texelFetch()` in the default window shader does not work with any `GL_TEXTURE_WRAP_x` parameter. As a result, a to-be-tiled root pixmap wasn't properly tiled and only visible in the original top-left corner. - Changed the default window shader to use `textureSize()` to scale the texture coordinates into the proper range for use with `texture2D()`. - Added a new uniform to the default post-processing shader containing the effective texture size for rounded corners calculation instead of relying on `textureSize()`.
tryone144
force-pushed
the
fix/use-effective-texture-size-for-corner-radius
branch
from
abbff8a
to
332501a
Compare
This was referenced Jan 23, 2023
|
Hmm, actually, should we have a different shader for root pixmap?, which by default can just do nothing. I remember there are someone asking for something like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rounded corner calculation only took the actual texture dimensions into account, effectively turning all pixels outside completely transparent. Furthermore,
texelFetch()in the default window shader does not work with any of theGL_TEXTURE_WRAP_xparameters.As a result, a to-be-tiled root pixmap wasn't properly tiled and only visible in the original top-left corner (see #970).
textureSize()to scale the texture coordinates into the proper range for use withtexture2D().textureSize().Related: #1000 (different fix for xrender)