-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for REAL type to PER codecs #107
Add support for REAL type to PER codecs #107
Conversation
Two things I am not so sure about:
I was not able to find a known working KPM serialization from srsRAN that includes REAL values, otherwise I would add that to the KPM test file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpicks, nothing major. Just changing cause to Generic
at most places and some other minor changes.
@gth828r Sorry I missed these questions
Yes, passing
This is fine. Well unit testing has not been as good for the codecs part in general, so if required we can revisit that. |
I should be able to address these and update the PR tomorrow morning KST. Sorry for the delay! |
No issues, take your time! Thanks for the PR! |
* For encode, support all special values and encode standard values as base 10 ISO 6093 NR3 for now. * For decode, support: * All special values * All binary encoded values (base 2, 8, or 16) * All base 10 encoded values (ISO 6093 NR1, NR2, and NR3) * Future work: Add support for encoding as binary, as well as NR1 and NR2. Selection needs to be based on some additional inputs. Addresses ystero-dev#100
490f55f
to
abe67fb
Compare
Addresses #100