-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VidLii] Add 720p support (yt-dlp backport-ish) #30924
Conversation
Also fix a bug with the view count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
Just a few observations.
Co-authored-by: dirkf <fieldhouse@gmx.net>
* tags: ['1', '2'] -> list * self._check_formats() used for checking HD url * self._search_regex -> self._html_search_regex Co-authored-by: dirkf <fieldhouse@gmx.net>
We don't need to check if the 360p source is there
@dirkf can this be re-reviewed? Looks like it got lost in the sea of current PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine with this change.
* https://github.com/ytdl-org/youtube-dl: [VidLii] Add 720p support (ytdl-org#30924) [ORF] Skip tests with limited availability [ORF] Re-factor and update`ORFFM4StoryIE` * fix getting media via DASH instead of inaccessible mp4 * also get in-page YT media [ORF] Support sound.orf.at, updating `ORFRadioIE` * maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates [ORF] Support on.orf.at, replacing `ORFTVthekIE` * add `ORFONIE`, back-porting yt-dlp PR yt-dlp/yt-dlp#9113 and friends: thx HobbyistDev, TuxCoder, seproDev * re-factor to support livestreams via new `ORFONliveIE` [test] Improve download test * skip reason can't be unicode in Py2 * remove duplicate assert...Equal functions [core] Re-factor with `_fill_common_fields()` as used in yt-dlp [core] Safer handling of nested playlist data [mixcloud] updated mixcloud API server address (ytdl-org#32557)
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Adds HD support to VidLii.
This was originally done in #29291, but I deleted that fork a long time ago so I can't make any more edits to it.