Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixcloud] updated mixcloud API server address #32557

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

kmnx
Copy link
Contributor

@kmnx kmnx commented Sep 13, 2023

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

The mixcloud API address changed from www.mixcloud.com/graphql to app.mixcloud.com/graphql
This PR updates the address to restore functionality.

@kmnx kmnx changed the title updated mixcloud API server address [mixcloud] updated mixcloud API server address Sep 16, 2023
@dirkf
Copy link
Contributor

dirkf commented Dec 12, 2023

Is there an issue for this problem, or are #32383, #32387 related?

@kmnx
Copy link
Contributor Author

kmnx commented Dec 13, 2023

there is no issue for this PR.
the mentioned issues are unrelated, both issues are from before the API URL changed.
also one is about soundcloud, not mixcloud.
i can't reproduce either issue as soundcloud works instantly and mixcloud works with this PR. even without this PR the error is different, mixcloud does not give a 403 for me even with wrong API URL.

dirkf

This comment was marked as outdated.

@dirkf dirkf linked an issue Mar 30, 2024 that may be closed by this pull request
1 task
@dirkf dirkf merged commit 88bd8b9 into ytdl-org:master Jun 11, 2024
14 checks passed
@dirkf
Copy link
Contributor

dirkf commented Jun 11, 2024

Thx @kmnx, @djkraven.

github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Jun 11, 2024
* https://github.com/ytdl-org/youtube-dl:
  [VidLii] Add 720p support (ytdl-org#30924)
  [ORF] Skip tests with limited availability
  [ORF] Re-factor and update`ORFFM4StoryIE` * fix getting media via DASH instead of inaccessible mp4 * also get in-page YT media
  [ORF] Support sound.orf.at, updating `ORFRadioIE` * maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates
  [ORF] Support on.orf.at, replacing `ORFTVthekIE` * add `ORFONIE`, back-porting yt-dlp PR yt-dlp/yt-dlp#9113 and friends: thx HobbyistDev, TuxCoder, seproDev * re-factor to support livestreams via new `ORFONliveIE`
  [test] Improve download test * skip reason can't be unicode in Py2 * remove duplicate assert...Equal functions
  [core] Re-factor with `_fill_common_fields()` as used in yt-dlp
  [core] Safer handling of nested playlist data
  [mixcloud] updated mixcloud API server address (ytdl-org#32557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixcloud failing for below mentioned artist while working for many others tested
2 participants