-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FFmpegMetadata] Store release_year in the metadata #32310
base: master
Are you sure you want to change the base?
Conversation
According to https://kodi.wiki/view/Video_file_tagging as quoted in the source, ffmpeg knows of a |
@@ -451,7 +451,7 @@ def add(meta_list, info_list=None): | |||
# 4. http://atomicparsley.sourceforge.net/mpeg-4files.html | |||
|
|||
add('title', ('track', 'title')) | |||
add('date', 'upload_date') | |||
add('date', ('release_year', 'upload_date')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will set a year rather than the yyyymmdd value if both items are available. Shouldn't they be reversed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not. This field called "Year" in most media players.
@@ -451,7 +451,7 @@ def add(meta_list, info_list=None): | |||
# 4. http://atomicparsley.sourceforge.net/mpeg-4files.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The add()
function above could be improved based on yt-dlp (import T()
, traverse_obj()
, txt_or_none()
, variadic()
from ..utils
):
def add(meta_list, info_list=None):
if not meta_list:
return
meta_list = variadic(meta_list)
info_list = variadic(info_list) if info_list else meta_list
value = traverse_obj(info, (info_list, T(txt_or_none), any))
if value not in (None, ''):
value = value.replace('\0', '') # nul character cannot be passed in command line
metadata.update((meta_f, value) for meta_f in meta_list)
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Many music extractors returns only
release_year
field, and it is not stored in the metadata.