-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FFmpegMetadata] Store release_year in the metadata #32310
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -451,7 +451,7 @@ def add(meta_list, info_list=None): | |
# 4. http://atomicparsley.sourceforge.net/mpeg-4files.html | ||
|
||
add('title', ('track', 'title')) | ||
add('date', 'upload_date') | ||
add('date', ('release_year', 'upload_date')) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will set a year rather than the yyyymmdd value if both items are available. Shouldn't they be reversed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think not. This field called "Year" in most media players. |
||
add(('description', 'comment'), 'description') | ||
add('purl', 'webpage_url') | ||
add('track', 'track_number') | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
add()
function above could be improved based on yt-dlp (importT()
,traverse_obj()
,txt_or_none()
,variadic()
from..utils
):