[Soundcloud] Download Soundcloud GO+ high quality streams #32311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to propose this in #30998 instead? |
|
Sure. After that PR accepted I will add OAuth token extraction from the cookies |
dirkf
reviewed
Jul 4, 2024
youtube_dl/extractor/soundcloud.py
Outdated
| 'url': format_url, | ||
| 'preference': 10, | ||
| 'abr': (filesize and duration) and (filesize / duration * 8), |
There was a problem hiding this comment.
Suggested change
| 'abr': (filesize and duration) and (filesize / duration * 8), | |
| 'abr': int_or_none(filesize, invscale=8, scale=duration) |
dirkf
reviewed
Jul 4, 2024
| @@ -319,6 +324,7 @@ def _extract_info_dict(self, info, full_title=None, secret_token=None): | |||
| track_id = compat_str(info['id']) | |||
| title = info['title'] | |||
|
|
|||
| duration = info.get('duration') | |||
There was a problem hiding this comment.
Maybe use this in the returned info-dict, l.467 ?
dirkf
reviewed
Jul 4, 2024
youtube_dl/extractor/soundcloud.py
Outdated
| @@ -293,6 +293,11 @@ def _download_json(self, *args, **kwargs): | |||
| if non_fatal: | |||
There was a problem hiding this comment.
The condition above is too specific. The definition of InfoExtractor._download_json() that is being overridden makes fatal just a truthy/falsey value with default True. It should say:
non_fatal = not kwargs.get('fatal', True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Added ability to download high quality 256k AAC streams with a Soundcloud GO+ account using cookies
This is not the same as a #26265