-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Soundcloud] Download Soundcloud GO+ high quality streams #32311
base: master
Are you sure you want to change the base?
Conversation
Would you be able to propose this in #30998 instead? |
Sure. After that PR accepted I will add OAuth token extraction from the cookies |
youtube_dl/extractor/soundcloud.py
Outdated
'url': format_url, | ||
'preference': 10, | ||
'abr': (filesize and duration) and (filesize / duration * 8), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'abr': (filesize and duration) and (filesize / duration * 8), | |
'abr': int_or_none(filesize, invscale=8, scale=duration) |
@@ -319,6 +324,7 @@ def _extract_info_dict(self, info, full_title=None, secret_token=None): | |||
track_id = compat_str(info['id']) | |||
title = info['title'] | |||
|
|||
duration = info.get('duration') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use this in the returned info-dict, l.467 ?
youtube_dl/extractor/soundcloud.py
Outdated
@@ -293,6 +293,11 @@ def _download_json(self, *args, **kwargs): | |||
if non_fatal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition above is too specific. The definition of InfoExtractor._download_json()
that is being overridden makes fatal
just a truthy/falsey value with default True
. It should say:
non_fatal = not kwargs.get('fatal', True)
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Added ability to download high quality 256k AAC streams with a Soundcloud GO+ account using cookies
This is not the same as a #26265