[JSInterp, YouTube] Support YT player b22ef6e7 etc
#32845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds some extensions missing in 4652109 (from yt-dlp/yt-dlp#10362) Authored by: bashonly Co-authored by: dirkf
Thx: various yt-dlp authors
Passes tests from yt-dlp
5 tasks
6 tasks
|
👍 works for me, thanks! |
Grub4K
reviewed
Jul 10, 2024
| if obj == compat_str: | ||
| # Fixup prototype call | ||
| if isinstance(obj, type): | ||
| new_member, rest = member.partition('.')[0::2] |
There was a problem hiding this comment.
why not
Suggested change
| new_member, rest = member.partition('.')[0::2] | |
| new_member, _, rest = member.partition('.') |
There was a problem hiding this comment.
Call me a slicer rather than a destructurer. Also that's what I had in my somewhat similar code before I applied yt-dlp/yt-dlp#10392.
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 10, 2024
* support `prototype` for call() and apply() (yt-dlp/yt-dlp#10392, thx Grub4k) * map JS `Array` to `list`
* improve extraction of function name (like yt-dlp/yt-dlp#10390) * always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boilerplate: own/yt-dlp code, fix/improvement
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR supports YT player
b22ef6e7(probably just in time for it to be withdrawn).At the same time, the opportunity was taken to improve the alignment of the code and tests with yt-dlp.
Fixes #32842.
Supersedes, closes #32843.
Also included is a previously intended update to PR #32830.
Thx @Grub4K, @bashonly, @seproDev, @pukkandan and possibly others for yt-dlp code included here.