-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#23192] YSQL: Simplify/cleanup code in PgDml/PgSelect/PgSelectIndex etc
Summary: The diffs major changes are - Substitute `PgPrepareParameters` structure with the PgDml::PrepareParameters which contains only required fields (avoid having multiple source of same data) - Move `LoadTable` into `PgDml` class to avoid copy-paste implementations in subclasses - Remove redundant destructors - Change interface of several functions/methods from accepting output params to using Result (i.e. `Result<bool> SampleNextBlock()` instead of `Status SampleNextBlock(bool *has_more)`) - Add missed includes - Fix `*` and `&` alignment (i.e. use `auto&` vs `auto &`) - Make several methods `private` instead of `public` **Note:** This diff doesn't change any logic. No new unit tests is required. Jira: DB-12133 Test Plan: Jenkins Reviewers: amartsinchyk, telgersma Reviewed By: amartsinchyk Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36545
- Loading branch information
1 parent
db445ce
commit 47da28c
Showing
18 changed files
with
508 additions
and
697 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.