Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geo: Automatic creation of transaction status tables #10783

Closed
es1024 opened this issue Dec 4, 2021 · 1 comment
Closed

geo: Automatic creation of transaction status tables #10783

es1024 opened this issue Dec 4, 2021 · 1 comment
Assignees
@es1024
Labels
area/docdb YugabyteDB core features

Comments

@es1024
Copy link
Contributor

es1024 commented Dec 4, 2021

Description

Context: #9980, #10157

We currently support the creation of local transaction status tables in a two-step manual process (creating a new transaction status table with yb-admin create_transaction_table and then setting the placement with yb-admin modify_table_placement).

We should also additionally automatically create local transaction tables when a table is created under the following conditions:

  • it uses a tablespace which has placement information specified
  • there is no local transaction table for the tablespace yet
@es1024 es1024 added the area/docdb YugabyteDB core features label Dec 4, 2021
@es1024 es1024 self-assigned this Dec 4, 2021
This was referenced Jan 13, 2022
Open
Closed
@es1024 es1024 mentioned this issue Feb 3, 2022
Closed
es1024 added a commit that referenced this issue Feb 11, 2022
@es1024
[#10783] geo: Automatic creation of transaction status tables
add3cec 
Summary:
Added attempt to automatically create local transaction status tables when a table is
created using a tablespace that has placement information set, if no such table has been created
for the tablespace yet; the transaction status table created will use the placement information
of the tablespace.

Depends on D13957.

Test Plan: Added GeoTransactionsTest.TestAutomaticLocalTransactionTableCreation; updated org.yb.pgsql.TestTablespaceProperties to check for placement of created transaction tables.

Reviewers: bogdan, mbautin, sergei, dsrinivasan

Reviewed By: sergei, dsrinivasan

Subscribers: sergei, rthallam, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D14255
@es1024
Copy link
Contributor Author

es1024 commented Feb 11, 2022

Added with add3cec.

@es1024 es1024 closed this as completed Feb 11, 2022
@bmatican bmatican mentioned this issue Feb 12, 2022
Closed
@es1024 es1024 mentioned this issue Feb 14, 2022
Closed
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Mar 8, 2022
@es1024
[yugabyte#10783] geo: Automatic creation of transaction status tables
0b53fba 
Summary:
Added attempt to automatically create local transaction status tables when a table is
created using a tablespace that has placement information set, if no such table has been created
for the tablespace yet; the transaction status table created will use the placement information
of the tablespace.

Depends on D13957.

Test Plan: Added GeoTransactionsTest.TestAutomaticLocalTransactionTableCreation; updated org.yb.pgsql.TestTablespaceProperties to check for placement of created transaction tables.

Reviewers: bogdan, mbautin, sergei, dsrinivasan

Reviewed By: sergei, dsrinivasan

Subscribers: sergei, rthallam, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D14255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@es1024 es1024

Labels
area/docdb YugabyteDB core features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@es1024