Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Replace DEFINE_ with DEFINE_UNKNOWN_ #14945

Closed
hari90 opened this issue Nov 10, 2022 · 0 comments
Closed

[DocDB] Replace DEFINE_ with DEFINE_UNKNOWN_ #14945

hari90 opened this issue Nov 10, 2022 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented Nov 10, 2022 •
edited
Loading

Jira Link: DB-4205

Description

Replace DEFINE_ with DEFINE_UNKNOWN_
@hari90 hari90 added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features labels Nov 10, 2022
@hari90 hari90 self-assigned this Nov 10, 2022
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Nov 10, 2022
hari90 added a commit that referenced this issue Nov 10, 2022
@hari90
[#14945] Replace DEFINE_ with DEFINE_NON_RUNTIME_
9e7a02c 
Summary:
Replace DEFINE_ with DEFINE_NON_RUNTIME_

Created with https://gist.githubusercontent.com/hari90/760596c0c8cb1d9b5b6fd99d643dba01/raw/0d967aec5c6cded897b462021648d183482c93df/gistfile1.txt

And fixed some minor lint errors

Test Plan: All jenkins tests

Reviewers: bogdan

Subscribers: asrivastava, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D21001
hari90 added a commit that referenced this issue Nov 10, 2022
@hari90
[#14945] Replace DEFINE_ with DEFINE_NON_RUNTIME_
12a052a 
Summary:
Replace DEFINE_ with DEFINE_NON_RUNTIME_

GH PR for easier review: #14946

Created with https://gist.githubusercontent.com/hari90/760596c0c8cb1d9b5b6fd99d643dba01/raw/0d967aec5c6cded897b462021648d183482c93df/gistfile1.txt

And fixed some minor lint errors

Fixes #14945

Test Plan: All jenkins tests

Reviewers: bogdan

Subscribers: asrivastava, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D21023
@hari90 hari90 changed the title [DocDB] Replace DEFINE_ with DEFINE_NON_RUNTIME_ [DocDB] Replace DEFINE_ with DEFINE_UNKNOWN_ Nov 10, 2022
hari90 added a commit that referenced this issue Nov 11, 2022
@hari90
[#14945] Replace DEFINE_ with DEFINE_UNKNOWN_
bc87bdf 
Summary:
Replace DEFINE_ with DEFINE_UNKNOWN_
These are older flags that we need to review and determine if they are RUNTIME, or NON_RUNTIME. Until then tagging them as UNKNOWN.

GH PR for easier review: #14953

Created with https://gist.githubusercontent.com/hari90/760596c0c8cb1d9b5b6fd99d643dba01/raw/3914a3a03187813738c78587f31bd0cfeeb58038/add_define_unknown.txt

And fixed some minor lint errors

Fixes #14945

Test Plan: All jenkins tests

Reviewers: bogdan

Subscribers: asrivastava, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D21024
@hari90 hari90 closed this as completed in afa3434 Nov 11, 2022
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Dec 7, 2022
@hari90
[yugabyte#14945] Replace DEFINE_ with DEFINE_UNKNOWN_
5ec0da7 
Summary:
Replace DEFINE_ with DEFINE_UNKNOWN_
These are older flags that we need to review and determine if they are RUNTIME, or NON_RUNTIME. Until then tagging them as UNKNOWN.

GH PR for easier review: yugabyte#14953

Created with https://gist.githubusercontent.com/hari90/760596c0c8cb1d9b5b6fd99d643dba01/raw/3914a3a03187813738c78587f31bd0cfeeb58038/add_define_unknown.txt

And fixed some minor lint errors

Fixes yugabyte#14945

Test Plan: All jenkins tests

Reviewers: bogdan, mihnea, smishra

Reviewed By: bogdan

Subscribers: jenkins-bot, yugaware, asrivastava, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D21002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci