Add DEFINE_UNKNOWN_ [Just for readability of a Phabricator diff. Will not Merge] #14953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Replace DEFINE_ with DEFINE_NON_RUNTIME_ GH PR for easier review: #14946 Created with https://gist.githubusercontent.com/hari90/760596c0c8cb1d9b5b6fd99d643dba01/raw/0d967aec5c6cded897b462021648d183482c93df/gistfile1.txt And fixed some minor lint errors Fixes #14945 Test Plan: All jenkins tests Reviewers: bogdan Subscribers: asrivastava, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D21023
hari90
changed the title
Summary: Replace DEFINE_ with DEFINE_UNKNOWN_ These are older flags that we need to review and determine if they are RUNTIME, or NON_RUNTIME. Until then tagging them as UNKNOWN. GH PR for easier review: #14953 Created with https://gist.githubusercontent.com/hari90/760596c0c8cb1d9b5b6fd99d643dba01/raw/3914a3a03187813738c78587f31bd0cfeeb58038/add_define_unknown.txt And fixed some minor lint errors Fixes #14945 Test Plan: All jenkins tests Reviewers: bogdan Subscribers: asrivastava, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D21024
hari90
added a commit
that referenced
this pull request
Nov 11, 2022
Summary: Replace DEFINE_ with DEFINE_UNKNOWN_ These are older flags that we need to review and determine if they are RUNTIME, or NON_RUNTIME. Until then tagging them as UNKNOWN. GH PR for easier review: #14953 Created with https://gist.githubusercontent.com/hari90/760596c0c8cb1d9b5b6fd99d643dba01/raw/3914a3a03187813738c78587f31bd0cfeeb58038/add_define_unknown.txt And fixed some minor lint errors Fixes #14945 Test Plan: All jenkins tests Reviewers: bogdan, mihnea, smishra Reviewed By: bogdan Subscribers: jenkins-bot, yugaware, asrivastava, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D21002
jayant07-yb
pushed a commit
to jayant07-yb/yugabyte-db
that referenced
this pull request
Dec 7, 2022
Summary: Replace DEFINE_ with DEFINE_UNKNOWN_ These are older flags that we need to review and determine if they are RUNTIME, or NON_RUNTIME. Until then tagging them as UNKNOWN. GH PR for easier review: yugabyte#14953 Created with https://gist.githubusercontent.com/hari90/760596c0c8cb1d9b5b6fd99d643dba01/raw/3914a3a03187813738c78587f31bd0cfeeb58038/add_define_unknown.txt And fixed some minor lint errors Fixes yugabyte#14945 Test Plan: All jenkins tests Reviewers: bogdan, mihnea, smishra Reviewed By: bogdan Subscribers: jenkins-bot, yugaware, asrivastava, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D21002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.dev.yugabyte.com/D21002