-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#7846, #11532] Update xcluster docs #11534
Conversation
✔️ Deploy Preview for infallible-bardeen-164bc9 ready! 🔨 Explore the source changes: 1fbc961 🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/621053cf636e2d0008233054 😎 Browse the preview: https://deploy-preview-11534--infallible-bardeen-164bc9.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Believe the rest of the TBD GH issues
don't have issues atm
docs/content/latest/architecture/docdb-replication/async-replication.md
Outdated
Show resolved
Hide resolved
docs/content/latest/architecture/docdb-replication/async-replication.md
Outdated
Show resolved
Hide resolved
docs/content/latest/architecture/docdb-replication/async-replication.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmatican Thanks for doing this, changes look good to me for the first pass. We need to use 'Source' and 'Target' terms everywhere (rather than producer, consumer, sink and so on). It's okay to create a follow-up PR to rename these terms.
@ymahajan Agreed on changing to one single terminology, but we also have diagrams which would have to change and I didn't want to touch those.. |
Remove references to master / slave Beef up topology section Changed main Features section to talk about the architectural pieces (eg: at-least-once semantics, multi-shard txns, conflict resolution) Polished Limitations section Added GH issues to some known items Beef up DDL section with mentions to DROP & TRUNCATE Added Scalability section Added Kubernetes section Added cross-feature integration section with Supported and Not yet supported sub-sections
Updating the feature and limitations section of the xcluster docs:
Features
section to talk about the architectural pieces (eg: at-least-once semantics, multi-shard txns, conflict resolution)Limitations
sectionSupported
andNot yet supported
sub-sectionsStill has a couple of TBD items, mostly for GH issues, pending eng and product review.