Date and Number formatting

[ashiksmd]

As requested, branched with only the code, along with just the root locale data. Extra locale data has been removed.
(See also pr #348 which this is derived from.)

[rgrove]

Please don't define custom exception classes. This is widely considered bad practice in JS. In YUI, you should use Y.error().

[mattparker]

For info: I've been working on parsing date/time strings into timestamps, along with relative changes - basically a full implementation of php's strtotime(), but with more (ie some) Internationalization support.

It's some way from being finished, but is https://github.com/mattparker/strtotime I intend it to go in the new gallery, eventually. The README will tell you what it does (and it does what it says): but I wouldn't suggest spending any time reading the code because there's a bunch of changes I want to make still (the code and I are on a break at the moment!).

More directly related to this: one thing that it occurred to me to do after the last lot of commits to strotime is to strip out timezone support (strtotime parses string timestamps, of which there are a lot), and which also appear here. And there's timezone string info (which could be significantly minified, incidentally) - so perhaps timezone data needs to be pulled out.

Other general comments on this PR: it's not at all clear what this does that Y.Date.format doesn't. I'm not actually very clear what this does do at all. It doesn't read like javascript.

[rgrove]

-1

This code makes no apparent effort to adhere to YUI best practices or coding standards. It hasn't even been linted. It is written in a verbose, repetitive, copy/paste-heavy, Java-like style that doesn't reflect modern JavaScript conventions. For example, in multiple places it modifies String.prototype to add a trim() method, which is not only a violation of fundamental good practice, it's also unnecessary because YUI has Y.Lang.trim().

Furthermore, the code is poorly commented, undocumented, and is presented here in a monolithic pull request with no description. It is virtually impossible to review, and my line comments above are merely a surface skim.

This should not go into YUI in this form or in anything like this form.

[davglass]

After reading (or trying to read) this code, I'm a 👎 on this until it get's cleaned up.

There are several design flaws in this that make it unacceptable to merge in this format.

The String.prototype stuff is easy to replace and do properly, but there are very large parts of this code that just look "wrong" and look like they are a direct port from Java.

[davglass]

Global Variable.

[davglass]

Bad code smell here, 2 while loops, 2 for loops, continue's and break's just smells bad to me.

[davglass]

I pulled this in locally and I can't even get the tests to pass. It needs linting very badly and it needs it globals checked. I found way too may leaking vars.

[davglass]

Just adding here for posterity: yogi [warn] lint found a total of 1063 errors.

[davglass]

Forgot to mention that this all needs YUIDoc comments added to every function.

[davglass]

Closed based on Open Hangout, recommending that this move into Gallery.