Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderer: Don't panic for unknown NodeKind #107

Closed
wants to merge 1 commit into from
Closed

renderer: Don't panic for unknown NodeKind #107

wants to merge 1 commit into from

Commits on Mar 6, 2020

  1. renderer: Don't panic for unknown NodeKind 

    When rendering a Node, Renderer looks up the NodeRenderer for that
node's kind in a slice. That will panic with an "index out of range"
error if a node renderer for that node kind has not been registered.

This change verifies that a node renderer is available for that node
kind before attempting to use it, and instead of panicking, returns an
informative error message.
    @abhinav
    abhinav committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    a2b8e64 View commit details
    Browse the repository at this point in the history